Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better naming and structure of the arrow/data/entity store/db #4437

Closed
1 task done
emilk opened this issue Dec 5, 2023 · 0 comments · Fixed by #4672
Closed
1 task done

Better naming and structure of the arrow/data/entity store/db #4437

emilk opened this issue Dec 5, 2023 · 0 comments · Fixed by #4672
Labels
🏎️ Quick Issue Can be fixed in a few hours or less 🚜 refactor Change the code, not the functionality

Comments

@emilk
Copy link
Member

emilk commented Dec 5, 2023 •
edited
Loading

Confusing:

  • The top-level type in re_arrow_store is called DataStore
  • The top-level type in re_data_store is called StoreDb

Questions:

  • Rename DataStore to ArrowStore to indicate how low-level/general it is?
  • Rename StoreDb to EntityDb ?

Actions:
@emilk emilk added 🚜 refactor Change the code, not the functionality 🏎️ Quick Issue Can be fixed in a few hours or less labels Dec 5, 2023
@emilk emilk changed the title Better naming and structure of the arrow/data/etntiy store/db Better naming and structure of the arrow/data/entity store/db Dec 5, 2023
@emilk emilk mentioned this issue Dec 6, 2023
Merged
4 tasks
emilk added a commit that referenced this issue Dec 7, 2023
@emilk
Remove EntityDb, inlining it into StoreDb (#4447)
3ab8d0a 
### What
* Part of #4437

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
  * Full build: [app.rerun.io](https://app.rerun.io/pr/4447/index.html)
* Partial build:
[app.rerun.io](https://app.rerun.io/pr/4447/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
- Useful for quick testing when changes do not affect examples in any
way
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4447)
- [Docs
preview](https://rerun.io/preview/6acb8166ae51b98c60e50f208f3640a1012e6fcb/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/6acb8166ae51b98c60e50f208f3640a1012e6fcb/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
@emilk emilk mentioned this issue Jan 4, 2024
Merged
4 tasks
emilk added a commit that referenced this issue Jan 4, 2024
@emilk
Rename StoreDb to EntityDb, re_data_store -> re_entity_db (#4670
a284fd6 
)

### What
* Part of #4437

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/4670/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/4670/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/4670/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4670)
- [Docs
preview](https://rerun.io/preview/0371d5ff4603f33ead320cfc99d933d564fa204a/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/0371d5ff4603f33ead320cfc99d933d564fa204a/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
emilk added a commit that referenced this issue Jan 4, 2024
@emilk
Rename re_arrow_store to re_data_store
82a2979 
Closes #4437
@emilk emilk mentioned this issue Jan 4, 2024
Merged
4 tasks
emilk added a commit that referenced this issue Jan 4, 2024
@emilk
Rename re_arrow_store to re_data_store
87346b3 
Closes #4437
Wumpf pushed a commit that referenced this issue Jan 4, 2024
@emilk
Rename re_arrow_store to re_data_store (#4672)
790f391 
Closes #4437

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/4672/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/4672/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/4672/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4672)
- [Docs
preview](https://rerun.io/preview/13d64ac10bc5bc0a712082dac786ac4849276b6d/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/13d64ac10bc5bc0a712082dac786ac4849276b6d/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🏎️ Quick Issue Can be fixed in a few hours or less 🚜 refactor Change the code, not the functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename re_arrow_store to re_data_store rerun-io/rerun
1 participant
@emilk