-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Local-first wheel publishing #4454
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
6a3c2e9
update pip index job
jprochazk 2beefdd
gitignore dist
jprochazk 4eb965d
add `build_and_upload_wheels.py`
jprochazk fb73d41
update workflows to use new wheel build
jprochazk 285240e
gitignore wheels
jprochazk 335afb4
move `check_expected_wheels` into `wheel_utils.py`
jprochazk e636f39
publish wheels via script
jprochazk 833b76b
use python3
jprochazk f6e76ce
fix wheel repack
jprochazk fadac41
fix lint
jprochazk 9897532
remove dead code
jprochazk 5a7bc84
Merge branch 'main' into jan/release-build-local
jprochazk f5b2ce0
remove repack + add `compat` arg
jprochazk 68c7fa0
fix lint
jprochazk 00a3b04
Merge branch 'main' into jan/release-build-local
jprochazk fcdc2bc
Merge branch 'main' into jan/release-build-local
jprochazk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,10 +6,10 @@ on: | |
| CONCURRENCY: | ||
| required: true | ||
| type: string | ||
| MATURIN_FEATURE_FLAGS: | ||
| required: false | ||
| MODE: | ||
| description: "The build mode, either `pypi` or `pr`" | ||
| required: true | ||
| type: string | ||
| default: "--no-default-features --features pypi" | ||
| PLATFORM: | ||
| required: true | ||
| type: string | ||
|
|
@@ -125,45 +125,32 @@ jobs: | |
| workload_identity_provider: ${{ secrets.GOOGLE_WORKLOAD_IDENTITY_PROVIDER }} | ||
| service_account: ${{ secrets.GOOGLE_SERVICE_ACCOUNT }} | ||
|
|
||
| - uses: prefix-dev/[email protected] | ||
| with: | ||
| pixi-version: v0.6.0 | ||
|
|
||
| - name: Install dependencies | ||
| shell: bash | ||
| run: | | ||
| pixi run rustup target add ${{ needs.set-config.outputs.TARGET }} | ||
| pixi run pip install -r rerun_py/requirements-build.txt | ||
| rustup target add ${{ needs.set-config.outputs.TARGET }} | ||
| pip install -r rerun_py/requirements-build.txt | ||
| pip install google-cloud-storage==2.9.0 | ||
|
|
||
| - name: Build web-viewer | ||
| # only build web-viewer when publishing to pypi | ||
| if: ${{ contains(inputs.MATURIN_FEATURE_FLAGS, 'pypi') }} | ||
| - name: Get sha | ||
| id: get-sha | ||
| shell: bash | ||
| run: | | ||
| pixi run cargo run --locked -p re_build_web_viewer -- --release | ||
| full_commit="${{ inputs.RELEASE_COMMIT || ((github.event_name == 'pull_request' && github.event.pull_request.head.ref) || github.sha) }}" | ||
| echo "sha=$(echo $full_commit | cut -c1-7)" >> "$GITHUB_OUTPUT" | ||
|
|
||
| # This does not run in the pixi environment, doing so | ||
| # causes it to select the wrong compiler on macos-arm | ||
| - name: Build Wheel | ||
| uses: PyO3/maturin-action@v1 | ||
| env: | ||
| # this stops `re_web_viewer_server/build.rs` from running | ||
| RERUN_IS_PUBLISHING: true | ||
| with: | ||
| maturin-version: "0.14.17" | ||
| manylinux: manylinux_2_31 | ||
| container: off | ||
| command: build | ||
| args: | | ||
| --manifest-path rerun_py/Cargo.toml | ||
| --release | ||
| --target ${{ needs.set-config.outputs.TARGET }} | ||
| ${{ inputs.MATURIN_FEATURE_FLAGS }} | ||
| --out dist | ||
| - name: Build | ||
| shell: bash | ||
| run: | | ||
| python3 scripts/ci/build_and_upload_wheels.py \ | ||
| --mode ${{ inputs.MODE }} \ | ||
| --target ${{ needs.set-config.outputs.TARGET }} \ | ||
| --dir commit/${{ steps.get-sha.outputs.sha }}/wheels \ | ||
| --compat manylinux_2_31 | ||
|
|
||
| - name: Save wheel artifact | ||
| if: ${{ inputs.WHEEL_ARTIFACT_NAME != '' }} | ||
| uses: actions/upload-artifact@v3 | ||
| with: | ||
| name: ${{inputs.WHEEL_ARTIFACT_NAME}} | ||
| path: dist | ||
| path: dist/${{ needs.set-config.outputs.TARGET }} | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does anything use the intermediate github artifact now, or can this go away with everything just using gcloud?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are jobs using it still, but it's possible to remove it altogether. would like to leave that for another PR