Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local-first wheel publishing #4454

Merged
merged 16 commits into from
Dec 11, 2023
Merged

Local-first wheel publishing #4454

merged 16 commits into from
Dec 11, 2023

Conversation

jprochazk
Copy link
Member

@jprochazk jprochazk commented Dec 7, 2023

What

Based on #4275
Part of #4169

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
    • Full build: app.rerun.io
    • Partial build: app.rerun.io - Useful for quick testing when changes do not affect examples in any way
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@jprochazk jprochazk marked this pull request as ready for review December 7, 2023 12:43
@jprochazk jprochazk requested a review from jleibs December 7, 2023 12:43
scripts/ci/build_and_upload_wheels.py Outdated Show resolved Hide resolved
scripts/ci/build_and_upload_wheels.py Outdated Show resolved Hide resolved
Copy link
Member

@jleibs jleibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks nice (assuming it works).

Comment on lines 150 to +155
- name: Save wheel artifact
if: ${{ inputs.WHEEL_ARTIFACT_NAME != '' }}
uses: actions/upload-artifact@v3
with:
name: ${{inputs.WHEEL_ARTIFACT_NAME}}
path: dist
path: dist/${{ needs.set-config.outputs.TARGET }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does anything use the intermediate github artifact now, or can this go away with everything just using gcloud?

Copy link
Member Author

@jprochazk jprochazk Dec 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are jobs using it still, but it's possible to remove it altogether. would like to leave that for another PR

scripts/ci/build_and_upload_wheels.py Outdated Show resolved Hide resolved
@jprochazk jprochazk merged commit bd0397a into main Dec 11, 2023
40 checks passed
@jprochazk jprochazk deleted the jan/release-build-local branch December 11, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants