Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shared recordings 2: exposing recording_id in C and C++ SDKs #4384

Merged
merged 7 commits into from
Nov 30, 2023
Merged

Shared recordings 2: exposing recording_id in C and C++ SDKs #4384

merged 7 commits into from
Nov 30, 2023

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Nov 29, 2023 •
edited by github-actions bot
Loading

What the title says.

Part of a PR series to fix #4055 once and for all:

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested app.rerun.io (if applicable)
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@teh-cmc teh-cmc added 🧑‍💻 dev experience developer experience (excluding CI) 🌊 C++ API C/C++ API specific include in changelog labels Nov 29, 2023
@teh-cmc teh-cmc force-pushed the cmc/shared_recordings_1_rust branch from d1d9f72 to d21853c Compare November 29, 2023 10:48
This was referenced Nov 29, 2023
Merged
Merged
@teh-cmc teh-cmc force-pushed the cmc/shared_recordings_2_cpp branch 2 times, most recently from dc5774d to bf3ea21 Compare November 29, 2023 10:52
@teh-cmc teh-cmc force-pushed the cmc/shared_recordings_1_rust branch from d21853c to 376df07 Compare November 29, 2023 10:54
@teh-cmc teh-cmc force-pushed the cmc/shared_recordings_2_cpp branch from bf3ea21 to 157b0ca Compare November 29, 2023 10:55
@teh-cmc teh-cmc marked this pull request as ready for review November 29, 2023 10:57
@teh-cmc teh-cmc added the do-not-merge Do not merge this PR label Nov 29, 2023
@teh-cmc
Copy link
Member Author

teh-cmc commented Nov 29, 2023

Windows fails with fatal error C1083: Cannot open include file: 'unistd.h': No such file or directory.

Please bless me with you knowledge @Wumpf 🧘

Wumpf
Wumpf requested changes Nov 29, 2023
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost :)

crates/rerun_c/src/lib.rs Show resolved Hide resolved
examples/cpp/shared_recording/main.cpp Outdated Show resolved Hide resolved
rerun_cpp/src/rerun/recording_stream.hpp Outdated Show resolved Hide resolved
@teh-cmc teh-cmc requested a review from Wumpf November 30, 2023 14:02
@teh-cmc teh-cmc force-pushed the cmc/shared_recordings_2_cpp branch from d788b73 to c4688be Compare November 30, 2023 14:05
@teh-cmc teh-cmc removed the do-not-merge Do not merge this PR label Nov 30, 2023
Wumpf
Wumpf approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect!

Base automatically changed from cmc/shared_recordings_1_rust to main November 30, 2023 14:44
teh-cmc added a commit that referenced this pull request Nov 30, 2023
@teh-cmc
Shared recordings 1: exposing recording_id in Rust SDK (#4383)
e81f44d 
We already exposed a way of configuring the `StoreId`, but this is an
internal concept that we have never communicated anywhere and is very
likely to be unstable as the way we do blueprint recordings evolve (also
it's been known to confuse users).

This adds a simple, straightforward way of configuring the
`recording_id`, akin to what we have in the Python SDK.

---

Part of a PR series to fix #4055 once and for all:
- #4383
- #4384
- #4385
@teh-cmc teh-cmc merged commit 0d87441 into main Nov 30, 2023
44 of 45 checks passed
@teh-cmc teh-cmc deleted the cmc/shared_recordings_2_cpp branch November 30, 2023 14:44
teh-cmc added a commit that referenced this pull request Nov 30, 2023
@teh-cmc
Shared recordings 3: add how-to guide (#4385)
a4b1095 
What the title says.

Rendered:

![image](https://github.com/rerun-io/rerun/assets/2910679/1734fdcf-7bc4-4521-91f8-f906610cf974)


---

Part of a PR series to fix #4055 once and for all:
- #4383
- #4384
- #4385
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
🌊 C++ API C/C++ API specific 🧑‍💻 dev experience developer experience (excluding CI) include in changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Doc: add a "How to record from multiple places"
2 participants
@teh-cmc @Wumpf