address PR comments

rerun-io · Nov 30, 2023 · d788b73 · d788b73
1 parent 54f92d9
commit d788b73
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 7 deletions.
diff --git a/examples/cpp/shared_recording/main.cpp b/examples/cpp/shared_recording/main.cpp
@@ -18,11 +18,7 @@ int main() {
         rerun::RecordingStream("rerun_example_shared_recording", "my_shared_recording");
     rec.spawn().exit_on_failure();
 
-    int pid = getpid();
-    std::ostringstream oss;
-    oss << "Hello from " << pid;
-
-    rec.log("updates", rerun::TextLog(oss.str()));
+    rec.log("updates", rerun::TextLog(std::string("Hello from ") + std::to_string(getpid())));
 
     std::cout << "Run me again to append more data to the recording!" << std::endl;
 }
diff --git a/rerun_cpp/src/rerun/recording_stream.cpp b/rerun_cpp/src/rerun/recording_stream.cpp
@@ -30,7 +30,7 @@ namespace rerun {
     }
 
     RecordingStream::RecordingStream(
-        std::string_view app_id, std::optional<std::string_view> recording_id, StoreKind store_kind
+        std::string_view app_id, std::string_view recording_id, StoreKind store_kind
     )
         : _store_kind(store_kind) {
         check_binary_and_header_version_match().handle();

diff --git a/rerun_cpp/src/rerun/recording_stream.hpp b/rerun_cpp/src/rerun/recording_stream.hpp
@@ -62,7 +62,7 @@ namespace rerun {
         /// \param recording_id The user-chosen name of the recording being logged to.
         /// \param store_kind Whether to log to the recording store or the blueprint store.
         RecordingStream(
-            std::string_view app_id, std::optional<std::string_view> recording_id = std::nullopt,
+            std::string_view app_id, std::string_view recording_id = std::string_view(),
             StoreKind store_kind = StoreKind::Recording
         );
         ~RecordingStream();