Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All C++ preprocessor macros start now with RR_ (instead of a mix of RR_ and RERUN_) #4371

Merged
merged 2 commits into from
Nov 28, 2023
Merged

All C++ preprocessor macros start now with RR_ (instead of a mix of RR_ and RERUN_) #4371

merged 2 commits into from
Nov 28, 2023

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Nov 28, 2023 •
edited by github-actions bot
Loading

What

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested app.rerun.io (if applicable)
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@Wumpf Wumpf merged commit b4dff2b into main Nov 28, 2023
44 checks passed
@Wumpf Wumpf deleted the andreas/cpp/unify-cpp-preprocessor branch November 28, 2023 16:48
teh-cmc pushed a commit that referenced this pull request Nov 30, 2023
@Wumpf @teh-cmc
All C++ preprocessor macros start now with RR_ (instead of a mix of R…
1eadb69 
…R_ and RERUN_) (#4371)

### What

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [app.rerun.io](https://app.rerun.io/pr/4371) (if
applicable)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4371)
- [Docs
preview](https://rerun.io/preview/cc4b9e350b6b5667dbf9289ecd0444a5acd7a9c8/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/cc4b9e350b6b5667dbf9289ecd0444a5acd7a9c8/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
🌊 C++ API C/C++ API specific include in changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Wumpf @emilk