Skip to content

Commit

Permalink
All C++ preprocessor macros start now with RR_ (instead of a mix of R…
Browse files Browse the repository at this point in the history
…R_ and RERUN_) (#4371)

### What

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [app.rerun.io](https://app.rerun.io/pr/4371) (if
applicable)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4371)
- [Docs
preview](https://rerun.io/preview/cc4b9e350b6b5667dbf9289ecd0444a5acd7a9c8/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/cc4b9e350b6b5667dbf9289ecd0444a5acd7a9c8/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
  • Loading branch information
Wumpf authored and teh-cmc committed Nov 30, 2023
1 parent 46dd085 commit 1eadb69
Show file tree
Hide file tree
Showing 25 changed files with 118 additions and 116 deletions.
2 changes: 2 additions & 0 deletions CODE_STYLE.md
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,8 @@ To accommodate for this and other languages, strings on the C interface are almo
### Misc
We don't add `inline` before class/struct member functions if they are inlined in the class/struct definition.

Preprocessor directives/macros are usually prefixed with `RR_`

Include what you use: if you use `std::vector`, then include `<vector>` - don't depend on a transitive include.


Expand Down
2 changes: 1 addition & 1 deletion crates/re_types_builder/src/codegen/cpp/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -442,7 +442,7 @@ impl QuotedObject {
#field_ident = std::move(#parameter_ident);
#NEWLINE_TOKEN
#gcc_ignore_comment
RERUN_WITH_MAYBE_UNINITIALIZED_DISABLED(return std::move(*this);)
RR_WITH_MAYBE_UNINITIALIZED_DISABLED(return std::move(*this);)
},
inline: true,
});
Expand Down
12 changes: 6 additions & 6 deletions rerun_cpp/src/rerun/archetypes/arrows3d.hpp

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions rerun_cpp/src/rerun/archetypes/asset3d.hpp

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 7 additions & 7 deletions rerun_cpp/src/rerun/archetypes/boxes2d.hpp

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 7 additions & 7 deletions rerun_cpp/src/rerun/archetypes/boxes3d.hpp

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions rerun_cpp/src/rerun/archetypes/depth_image.hpp

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion rerun_cpp/src/rerun/archetypes/image.hpp

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions rerun_cpp/src/rerun/archetypes/line_strips2d.hpp

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions rerun_cpp/src/rerun/archetypes/line_strips3d.hpp

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions rerun_cpp/src/rerun/archetypes/mesh3d.hpp

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 1eadb69

Please sign in to comment.