Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ SDK sanity checks now header/source version against rerun_c binary version #4330

Merged
merged 8 commits into from
Nov 27, 2023

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Nov 24, 2023

What

Tests erro'red correctly when I still had a longer string, looked like this:

-------------------------------------------------------------------------------
Scenario: RecordingStream can connect
      Given: a new RecordingStream
-------------------------------------------------------------------------------
/Users/andreas/dev/rerun-io/rerun/rerun_cpp/tests/recording_stream.cpp:433
...............................................................................

/Users/andreas/dev/rerun-io/rerun/rerun_cpp/tests/recording_stream.cpp:433: FAILED:
due to unexpected exception with message:
  Rerun_c SDK version and SDK header/source versions don't match match. Make
  sure to link against the correct version of the rerun_c library.
  Rerun_c version:
  re_sdk 0.11.0-alpha.1+dev [rustc 1.72.1 (d5c2e9c34 2023-09-13), LLVM 16.0.5]
  aarch64-apple-darwin
  SDK header/source version:
  0.11.0-alpha.1+dev

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested demo.rerun.io (if applicable)
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@Wumpf Wumpf added enhancement New feature or request 🌊 C++ API C/C++ API specific include in changelog labels Nov 24, 2023
@emilk emilk self-requested a review November 27, 2023 07:54
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good!

rerun_cpp/src/rerun/sdk_info.cpp Outdated Show resolved Hide resolved
rerun_cpp/src/rerun/sdk_info.cpp Outdated Show resolved Hide resolved
rerun_cpp/src/rerun/sdk_info.hpp Show resolved Hide resolved
@Wumpf Wumpf merged commit 7e6924f into main Nov 27, 2023
42 checks passed
@Wumpf Wumpf deleted the andreas/cpp/version-check branch November 27, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌊 C++ API C/C++ API specific enhancement New feature or request include in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sanity-check that the C header version and rerun_c library version is the same
2 participants