Support cmake install #4326
Merged
Support cmake install #4326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
added
enhancement
teh-cmc
approved these changes
Nov 24, 2023
... not on ci though, but I think I know why. |
Wumpf
force-pushed
the
andreas/cpp/cmake-install
branch
from
64cd7f3 to
976400b
Compare
revert previous attempts of putting them elsewhere because link order is important in C++ land...
4 tasks
Wumpf
added a commit
that referenced
this pull request
Nov 27, 2023
…y version (#4330) ### What * Fixes #3868 * Fixes left over to set generic package version from #4326 * Yes there's two levels of regex'ing existing files now, but I'm happy with it because it avoids etching the version into more places: The repo cmake setup first figures out the rerun version by taking a look at Cargo.toml and puts that into rerun.h which we commit. Then when doing an install (in repo or outside!) we check rerun.h's version and put that into the CMake Install shenanigans Tests erro'red correctly when I still had a longer string, looked like this: ``` ------------------------------------------------------------------------------- Scenario: RecordingStream can connect Given: a new RecordingStream ------------------------------------------------------------------------------- /Users/andreas/dev/rerun-io/rerun/rerun_cpp/tests/recording_stream.cpp:433 ............................................................................... /Users/andreas/dev/rerun-io/rerun/rerun_cpp/tests/recording_stream.cpp:433: FAILED: due to unexpected exception with message: Rerun_c SDK version and SDK header/source versions don't match match. Make sure to link against the correct version of the rerun_c library. Rerun_c version: re_sdk 0.11.0-alpha.1+dev [rustc 1.72.1 (d5c2e9c34 2023-09-13), LLVM 16.0.5] aarch64-apple-darwin SDK header/source version: 0.11.0-alpha.1+dev ``` ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/4330) (if applicable) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG - [PR Build Summary](https://build.rerun.io/pr/4330) - [Docs preview](https://rerun.io/preview/72b1b7eedaa4934a8a34d1ab498c9b7752dd8125/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/72b1b7eedaa4934a8a34d1ab498c9b7752dd8125/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
RERUN_CPP_SOURCE_DIR) #4313Support and document use of CMake install.
Minimal example has a switch to use
find_package. Not rolling it out to others because it's just not as ergonomic, don't want to advertise it all that much. However, the minimal example is used in the sdk package script to test that install is in order before uploading the package script (runs locally). I manually tested the case of a rerun install depend on an arrow system install.Checklist