Make on TextLogLevel PascalCase (instead of SCREAMING CASE) to avoid clashes with preprocessor defines

CODE_STYLE.md

@@ -189,11 +189,18 @@ class Rect {
 }
 ```
 
+### Constants & Enums
+
+Constants & enum values have PascalCase names.
+
+When possible, use `constexpr` for (global & struct/class scoped) constants.
+
 ### String handling
 Whenever possible we use `std::string_view` to pass strings.
 
 To accommodate for this and other languages, strings on the C interface are almost never expected to be null-terminated and are always passed along with a byte length using `rr_string`.
 
+
 ### Misc
 We don't add `inline` before class/struct member functions if they are inlined in the class/struct definition.
 

crates/re_types_builder/src/codegen/cpp/mod.rs

@@ -690,7 +690,7 @@ impl QuotedObject {
         // Putting non-POD types in a union requires C++11.
         //
         // enum class Rotation3DTag : uint8_t {
-        //     NONE = 0,
+        //     None = 0,
         //     Quaternion,
         //     AxisAngle,
         // };
@@ -722,7 +722,7 @@ impl QuotedObject {
             let comment = quote_doc_comment(
                 "Having a special empty state makes it possible to implement move-semantics. \
                 We need to be able to leave the object in a state which we can run the destructor on.");
-            let tag_name = format_ident!("NONE");
+            let tag_name = format_ident!("None");
             quote! {
                 #NEWLINE_TOKEN
                 #comment
@@ -854,7 +854,7 @@ impl QuotedObject {
             let destructor_match_arms = std::iter::once({
                 let comment = quote_comment("Nothing to destroy");
                 quote! {
-                    case detail::#tag_typename::NONE: {
+                    case detail::#tag_typename::None: {
                         #NEWLINE_TOKEN
                         #comment
                     } break;
@@ -948,7 +948,7 @@ impl QuotedObject {
                         switch (other._tag) {
                             #(#placement_new_arms)*
 
-                            case detail::#tag_typename::NONE: {
+                            case detail::#tag_typename::None: {
                                 // there is nothing to copy
                             } break;
                         }
@@ -967,7 +967,7 @@ impl QuotedObject {
                                 #trivial_memcpy
                             } break;
 
-                            case detail::#tag_typename::NONE: {
+                            case detail::#tag_typename::None: {
                                 // there is nothing to copy
                             } break;
                         }
@@ -1020,7 +1020,7 @@ impl QuotedObject {
                     struct #pascal_case_ident {
                         #(#constants_hpp;)*
 
-                        #pascal_case_ident() : _tag(detail::#tag_typename::NONE) {}
+                        #pascal_case_ident() : _tag(detail::#tag_typename::None) {}
 
                         #copy_constructor
 
@@ -1235,7 +1235,7 @@ fn new_arrow_array_builder_method(
         },
         definition_body: quote! {
             if (memory_pool == nullptr) {
-                return Error(ErrorCode::UnexpectedNullArgument, "Memory pool is null.");
+                return rerun::Error(ErrorCode::UnexpectedNullArgument, "Memory pool is null.");
             }
             #NEWLINE_TOKEN
             #NEWLINE_TOKEN
@@ -1264,18 +1264,18 @@ fn fill_arrow_array_builder_method(
         docs: "Fills an arrow array builder with an array of this type.".into(),
         declaration: MethodDeclaration {
             is_static: true,
-            return_type: quote! { Error },
+            return_type: quote! { rerun::Error },
             // TODO(andreas): Pass in validity map.
             name_and_parameters: quote! {
                 fill_arrow_array_builder(arrow::#arrow_builder_type* #builder, const #type_ident* elements, size_t num_elements)
             },
         },
         definition_body: quote! {
             if (builder == nullptr) {
-                return Error(ErrorCode::UnexpectedNullArgument, "Passed array builder is null.");
+                return rerun::Error(ErrorCode::UnexpectedNullArgument, "Passed array builder is null.");
             }
             if (elements == nullptr) {
-                return Error(ErrorCode::UnexpectedNullArgument, "Cannot serialize null pointer to arrow array.");
+                return rerun::Error(ErrorCode::UnexpectedNullArgument, "Cannot serialize null pointer to arrow array.");
             }
             #NEWLINE_TOKEN
             #NEWLINE_TOKEN
@@ -1415,7 +1415,7 @@ fn quote_fill_arrow_array_builder(
                 quote! {
                     (void)num_elements;
                     if (true) { // Works around unreachability compiler warning.
-                        return Error(ErrorCode::NotImplemented, "TODO(andreas) Handle nullable extensions");
+                        return rerun::Error(ErrorCode::NotImplemented, "TODO(andreas) Handle nullable extensions");
                     }
                 }
             } else {
@@ -1470,7 +1470,7 @@ fn quote_fill_arrow_array_builder(
                             let error = format!("Failed to serialize {}::{}: nullable list types in unions not yet implemented", obj.name, variant.name);
                             quote! {
                                 (void)#variant_builder;
-                                return Error(ErrorCode::NotImplemented, #error);
+                                return rerun::Error(ErrorCode::NotImplemented, #error);
                             }
                         } else if arrow_builder_type == "ListBuilder" {
                             let field_name = format_ident!("{}", variant.snake_case_name());
@@ -1522,15 +1522,15 @@ fn quote_fill_arrow_array_builder(
                                     let error = format!("Failed to serialize {}::{}: objects ({:?}) in unions not yet implemented", obj.name, variant.name, element_type);
                                     quote! {
                                         (void)#variant_builder;
-                                        return Error(ErrorCode::NotImplemented, #error);
+                                        return rerun::Error(ErrorCode::NotImplemented, #error);
                                     }
                                 }
                             }
                         } else {
                             let error = format!("Failed to serialize {}::{}: {} in unions not yet implemented", obj.name, variant.name, arrow_builder_type);
                             quote! {
                                 (void)#variant_builder;
-                                return Error(ErrorCode::NotImplemented, #error);
+                                return rerun::Error(ErrorCode::NotImplemented, #error);
                             }
                         }
                     } else {
@@ -1559,7 +1559,7 @@ fn quote_fill_arrow_array_builder(
                         #NEWLINE_TOKEN
                         #NEWLINE_TOKEN
                         switch (union_instance._tag) {
-                            case detail::#tag_name::NONE: {
+                            case detail::#tag_name::None: {
                                 ARROW_RETURN_NOT_OK(variant_builder_untyped->AppendNull());
                             } break;
                             #(#tag_cases)*

docs/code-examples/text_log.cpp

@@ -6,5 +6,5 @@ int main() {
     const auto rec = rerun::RecordingStream("rerun_example_text_log");
     rec.spawn().exit_on_failure();
 
-    rec.log("log", rerun::TextLog("Application started.").with_level(rerun::TextLogLevel::INFO));
+    rec.log("log", rerun::TextLog("Application started.").with_level(rerun::TextLogLevel::Info));
 }

docs/code-examples/text_log_integration.cpp

@@ -10,17 +10,17 @@ void loguru_to_rerun(void* user_data, const loguru::Message& message) {
 
     rerun::TextLogLevel level;
     if (message.verbosity == loguru::Verbosity_FATAL) {
-        level = rerun::TextLogLevel::CRITICAL;
+        level = rerun::TextLogLevel::Critical;
     } else if (message.verbosity == loguru::Verbosity_ERROR) {
-        level = rerun::TextLogLevel::ERROR;
+        level = rerun::TextLogLevel::Error;
     } else if (message.verbosity == loguru::Verbosity_WARNING) {
-        level = rerun::TextLogLevel::WARN;
+        level = rerun::TextLogLevel::Warning;
     } else if (message.verbosity == loguru::Verbosity_INFO) {
-        level = rerun::TextLogLevel::INFO;
+        level = rerun::TextLogLevel::Info;
     } else if (message.verbosity == loguru::Verbosity_1) {
-        level = rerun::TextLogLevel::DEBUG;
+        level = rerun::TextLogLevel::Debug;
     } else if (message.verbosity == loguru::Verbosity_2) {
-        level = rerun::TextLogLevel::TRACE;
+        level = rerun::TextLogLevel::Trace;
     } else {
         level = rerun::TextLogLevel(std::to_string(message.verbosity));
     }
@@ -38,7 +38,7 @@ int main() {
     // Log a text entry directly:
     rec.log(
         "logs",
-        rerun::TextLog("this entry has loglevel TRACE").with_level(rerun::TextLogLevel::TRACE)
+        rerun::TextLog("this entry has loglevel TRACE").with_level(rerun::TextLogLevel::Trace)
     );
 
     loguru::add_callback(