-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make on TextLogLevel PascalCase (instead of SCREAMING CASE) to avoid clashes with preprocessor defines #4152
Conversation
…preprocessor defines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was my preferred choice, so I'm gonna approve this ;)
Alternative: use |
Discussed this a bit more on internal Slack: there's some risk that |
LEVEL_
to avoid clashes with preprocessor definesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
What
Considered also just using lower case on these (nobody would do
#define debug
, ... RIGHT?). But they are enum - like constants so all-caps felt appropriate.Checklist