Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MacOS C++ CI, add Linux C++20 CI #4120

Merged
merged 31 commits into from
Nov 2, 2023
Merged

Add MacOS C++ CI, add Linux C++20 CI #4120

merged 31 commits into from
Nov 2, 2023

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Nov 1, 2023 •
edited by github-actions bot
Loading

What

New way of doing test matrices: Load different json files to configure an entire job.
-> Much nicer config interface (a separate clean file <3) and less & less arcane job setup \o/

Adds tests for Mac AND Linux C++20!

Runs full matrix on main and whenever cpp/hpp/cmake changes are registered.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested demo.rerun.io (if applicable)
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@Wumpf Wumpf added 🧑‍💻 dev experience developer experience (excluding CI) 🌊 C++ API C/C++ API specific exclude from changelog PRs with this won't show up in CHANGELOG.md labels Nov 1, 2023
emilk
emilk approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to get this refactored into a proper matrix!

.github/workflows/on_pull_request.yml Outdated Show resolved Hide resolved
.github/workflows/on_pull_request.yml Outdated Show resolved Hide resolved
.github/workflows/on_push_main.yml Outdated Show resolved Hide resolved
.github/workflows/reusable_build_and_upload_rerun_cli.yml Show resolved Hide resolved
.github/workflows/reusable_checks_cpp.yml Outdated Show resolved Hide resolved
@Wumpf
Copy link
Member Author

Wumpf commented Nov 1, 2023

@emilk this is still under development, nothing is working yet ;)

@Wumpf Wumpf force-pushed the andreas/cpp/ci-matrix branch from b8e9685 to f7d859e Compare November 1, 2023 16:05
@Wumpf Wumpf force-pushed the andreas/cpp/ci-matrix branch from 1d58a3b to aa990f1 Compare November 1, 2023 17:02
@Wumpf Wumpf requested a review from emilk November 1, 2023 17:47
@Wumpf Wumpf marked this pull request as ready for review November 1, 2023 17:53
@Wumpf Wumpf requested review from emilk and removed request for emilk November 1, 2023 17:54
@Wumpf Wumpf added include in changelog and removed exclude from changelog PRs with this won't show up in CHANGELOG.md labels Nov 2, 2023
@Wumpf Wumpf changed the title Add MacOS C++ CI, refactor into test matrix Add MacOS C++ CI, add Linux C++20 C++ CI Nov 2, 2023
@Wumpf Wumpf changed the title Add MacOS C++ CI, add Linux C++20 C++ CI Add MacOS C++ CI, add Linux C++20 CI Nov 2, 2023
@Wumpf Wumpf merged commit 77926fe into main Nov 2, 2023
42 of 43 checks passed
@Wumpf Wumpf deleted the andreas/cpp/ci-matrix branch November 2, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jprochazk jprochazk jprochazk approved these changes

@emilk emilk Awaiting requested review from emilk

Assignees
No one assigned
Labels
🌊 C++ API C/C++ API specific 🧑‍💻 dev experience developer experience (excluding CI) include in changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add CI step for building C++ on Mac
3 participants
@Wumpf @emilk @jprochazk