I have no idea

rerun-io · Nov 1, 2023 · f7d859e · f7d859e
1 parent a03cbff
commit f7d859e
Showing 1 changed file with 16 additions and 18 deletions.
diff --git a/.github/workflows/on_pull_request.yml b/.github/workflows/on_pull_request.yml
@@ -22,31 +22,29 @@ jobs:
       PR_NUMBER: ${{ github.event.pull_request.number }}
     secrets: inherit
 
+  # cpp-paths-filter:
+  #   runs-on: ubuntu-latest
+  #   outputs:
+  #     cpp_changes: ${{ steps.filter.outputs.rerun_cpp }}
+  #   steps:
+  #   - uses: actions/checkout@v4
+  #     with:
+  #       ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.ref || '' }}
+  #   - uses: dorny/paths-filter@v2
+  #     id: filter
+  #     with:
+  #       filters: |
+  #         rerun_cpp:
+  #           - 'rerun_cpp/**'
 
-  cpp-paths-filter:
-    runs-on: ubuntu-latest
-    outputs:
-      cpp_changes: ${{ steps.filter.outputs.rerun_cpp }}
-    steps:
-    - uses: actions/checkout@v4
-      with:
-        ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.ref || '' }}
-    - uses: dorny/paths-filter@v2
-      id: filter
-      with:
-        filters: |
-          rerun_cpp:
-            - 'rerun_cpp/**'
-
-  # Run cpp tests for all platforms
   cpp-tests:
     name: "C++ tests"
     # Wait for the cpp-paths-filter to be completed before starting.
-    needs: cpp-paths-filter
+    #needs: cpp-paths-filter
     uses: ./.github/workflows/reusable_checks_cpp.yml
     with:
       CONCURRENCY: pr-${{ github.event.pull_request.number }}
-      FULL: ${{ needs.cpp-paths-filter.outputs.cpp_changes }}
+      FULL: true # ${{ needs.cpp-paths-filter.outputs.cpp_changes }}
     secrets: inherit
 
   min-test-wheel: