Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support pathlib.Path for rr.save #4036

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Support pathlib.Path for rr.save #4036

merged 1 commit into from
Oct 27, 2023

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Oct 27, 2023 •
edited by github-actions bot
Loading

What

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested demo.rerun.io (if applicable)
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@teh-cmc teh-cmc added 🐍 Python API Python logging API 🧑‍💻 dev experience developer experience (excluding CI) include in changelog labels Oct 27, 2023
@teh-cmc teh-cmc merged commit 4fed666 into main Oct 27, 2023
37 of 39 checks passed
@teh-cmc teh-cmc deleted the cmc/python_path_thingy branch October 27, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
🧑‍💻 dev experience developer experience (excluding CI) include in changelog 🐍 Python API Python logging API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rr.save not accepting pathlib.Path
2 participants
@teh-cmc @emilk