Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rr.save not accepting pathlib.Path #4024

Closed
roym899 opened this issue Oct 26, 2023 · 0 comments · Fixed by #4036
Closed

rr.save not accepting pathlib.Path #4024

roym899 opened this issue Oct 26, 2023 · 0 comments · Fixed by #4036
Assignees
Labels
😤 annoying Something in the UI / SDK is annoying to use enhancement New feature or request 👀 needs triage This issue needs to be triaged by the Rerun team

Comments

@roym899
Copy link
Collaborator

roym899 commented Oct 26, 2023

rr.save is only accepting strings currently, it would be nice to support pathlib.Path objects directly.

To Reproduce

import rerun as rr
import pathlib
rr.init("test")
rr.save(pathlib.Path("./test.rrd"))

gives

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File ".../lib/python3.10/site-packages/rerun_sdk/rerun/sinks.py", line 67, in save
    bindings.save(path=path, recording=recording)
TypeError: argument 'path': 'PosixPath' object cannot be converted to 'PyString'

Rerun version

rerun_py 0.9.1 [rustc 1.72.1 (d5c2e9c34 2023-09-13), LLVM 16.0.5] x86_64-unknown-linux-gnu 00fa796, built 2023-10-12T12:13:35Z
@roym899 roym899 added enhancement New feature or request 😤 annoying Something in the UI / SDK is annoying to use 👀 needs triage This issue needs to be triaged by the Rerun team labels Oct 26, 2023
@teh-cmc teh-cmc self-assigned this Oct 27, 2023
teh-cmc added a commit that referenced this issue Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
😤 annoying Something in the UI / SDK is annoying to use enhancement New feature or request 👀 needs triage This issue needs to be triaged by the Rerun team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants