Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spawn version compatibility check #4031

Merged
merged 4 commits into from
Oct 27, 2023
Merged

spawn version compatibility check #4031

merged 4 commits into from
Oct 27, 2023

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Oct 26, 2023 •
edited by github-actions bot
Loading

Nothing too fancy but should do the job!

image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested demo.rerun.io (if applicable)
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@teh-cmc teh-cmc added 🦀 Rust API Rust logging API 🧑‍💻 dev experience developer experience (excluding CI) 📺 re_viewer affects re_viewer itself 🌊 C++ API C/C++ API specific include in changelog labels Oct 26, 2023
@teh-cmc teh-cmc force-pushed the cmc/spawn_version_check branch from 849672f to 3735483 Compare October 26, 2023 17:20
@teh-cmc teh-cmc marked this pull request as draft October 26, 2023 17:22
@teh-cmc teh-cmc force-pushed the cmc/spawn_version_check branch from 3735483 to f26aae8 Compare October 26, 2023 17:25
@teh-cmc teh-cmc marked this pull request as ready for review October 26, 2023 17:26
emilk
emilk approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@emilk emilk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great idea! And such a helpful error message too ⭐⭐⭐⭐

crates/re_sdk/src/spawn.rs Outdated Show resolved Hide resolved
crates/re_sdk/src/spawn.rs Outdated Show resolved Hide resolved
@teh-cmc teh-cmc merged commit c929c34 into main Oct 27, 2023
34 checks passed
@teh-cmc teh-cmc deleted the cmc/spawn_version_check branch October 27, 2023 08:31
@teh-cmc teh-cmc mentioned this pull request Oct 27, 2023
Merged
4 tasks
teh-cmc added a commit that referenced this pull request Oct 27, 2023
@teh-cmc
spawn: versioned links for missing executable too (#4041)
c6c50d2 
Fixing an oversight from #4031: if the user doesn't have any executable
at all on their PATH, don't just blindly tell them to download latest,
it might not even be compatible! Use a versioned link in that case too,
where possible.

```sh
$ which rerun
which: no rerun in (...)

$ RUST_LOG=off cargo r -p code_examples --bin point3d_simple

Error: SpawnViewer(Failed to find Rerun Viewer executable in PATH.

    You can install an appropriate version of the Rerun Viewer via binary releases:
    * Using `cargo`: `cargo binstall --force [email protected]` (see https://github.com/cargo-bins/cargo-binstall)
    * Via direct download from our release assets: https://github.com/rerun-io/rerun/releases/0.10.0/
    * Using `pip`: `pip3 install rerun-sdk==0.10.0` (warning: pip version has slower start times!)

    For more information, refer to our complete install documentation over at:
    https://rerun.io/docs/getting-started/installing-viewer

PATH="...")
```
(This is using my local copy where everything is tagged as if `0.10.0`
was released)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
🌊 C++ API C/C++ API specific 🧑‍💻 dev experience developer experience (excluding CI) include in changelog 📺 re_viewer affects re_viewer itself 🦀 Rust API Rust logging API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spawning from $PATH should run a version compatibility check
2 participants
@teh-cmc @emilk