Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spawning from $PATH should run a version compatibility check #4001

Closed
teh-cmc opened this issue Oct 25, 2023 · 0 comments · Fixed by #4031
Closed

Spawning from $PATH should run a version compatibility check #4001

teh-cmc opened this issue Oct 25, 2023 · 0 comments · Fixed by #4031
Labels
🧑‍💻 dev experience developer experience (excluding CI)

Comments

@teh-cmc
Copy link
Member

teh-cmc commented Oct 25, 2023

We've recently added support for spawning from PATH in Rust, C and C++.
This is pretty nice but does have an implication: the Rerun Viewer executable in PATH should match the version of your SDK, otherwise you are likely in trouble.

The version mismatch will be detected by the viewer and generate a generic warning, but we can do a much better job in this specific instance and e.g. print out the correct download links.

The version of the viewer can be parsed from fork-exec'ing rerun --version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧑‍💻 dev experience developer experience (excluding CI)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant