Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new build Environment option for CondaBuild to improve conda-built artifacts #4015

Merged
merged 5 commits into from
Oct 26, 2023

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Oct 25, 2023

What

Resolves:

The main issue is that the conda environment dind't realize it was building a released version.

The conda build environment is special. The feedstock recipe downloads the source from the published artifact, so many of our checks related to things like branch-name aren't correct. Otherwise it's very close to the CI build environment.

This detects the environment and attempts to do more reasonable things where relevant.

Testing

  • I created a temporary branch in the rerun feedstock repository pointing to the source https://github.com/rerun-io/rerun/archive/refs/heads/jleibs/conda_examples.zip
  • I built using python build-locally.py linux_64_python3.10.____cpython
  • I ran the rerun version from the channel with RUST_LOG=debug
  • Confirmed correct attempted download location based on version:
    • Downloading .rrd file from "https://demo.rerun.io/version/0.10.0-alpha.7+dev/examples/plots/data.rrd"…

Related, I also need to remove RERUN_IS_PUBLISHING from the conda recipe. See:

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested demo.rerun.io (if applicable)
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@jleibs jleibs changed the title Add a new build Environment option for CondaBuild Add a new build Environment option for CondaBuild to improve conda-built artifacts Oct 25, 2023
@jleibs jleibs added 🧑‍💻 dev experience developer experience (excluding CI) include in changelog labels Oct 25, 2023
@jleibs jleibs marked this pull request as ready for review October 25, 2023 21:59
@teh-cmc teh-cmc merged commit 8385d63 into main Oct 26, 2023
28 checks passed
@teh-cmc teh-cmc deleted the jleibs/conda_examples branch October 26, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧑‍💻 dev experience developer experience (excluding CI) include in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants