Remove RERUN_IS_PUBLISHING and bump to 0.10.0 #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
4 tasks
|
I guess this requires the merge of the PR mentioned in the description right? You can also test it locally to change the source in the meta.yaml to a local version and run the |
teh-cmc
pushed a commit
to rerun-io/rerun
that referenced
this pull request
Oct 26, 2023
…ilt artifacts (#4015) Resolves: - #3908 The main issue is that the conda environment dind't realize it was building a released version. The conda build environment is special. The feedstock recipe downloads the source from the published artifact, so many of our checks related to things like branch-name aren't correct. Otherwise it's very close to the CI build environment. This detects the environment and attempts to do more reasonable things where relevant. ### Testing - I created a temporary branch in the rerun feedstock repository pointing to the source `https://github.com/rerun-io/rerun/archive/refs/heads/jleibs/conda_examples.zip` - I built using `python build-locally.py linux_64_python3.10.____cpython` - I ran the `rerun` version from the channel with `RUST_LOG=debug` - Confirmed correct attempted download location based on version: - `Downloading .rrd file from "https://demo.rerun.io/version/0.10.0-alpha.7+dev/examples/plots/data.rrd"…` Related, I also need to remove RERUN_IS_PUBLISHING from the conda recipe. See: - conda-forge/rerun-sdk-feedstock#17
jleibs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)Combined with the changes from:
This fixes:
RERUN_IS_PUBLISHINGis used for the crate publishing and Rerun now handles this properly by checking for theCONDA_BUILDenvironment variable.Note: this fix won't actually work until we release
rerun-0.10with the fix from rerun-io/rerun#4015