Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default DisconnectedSpaces boolean to true in Python #3760

Merged
merged 8 commits into from
Oct 10, 2023
Merged

Default DisconnectedSpaces boolean to true in Python #3760

merged 8 commits into from
Oct 10, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented Oct 10, 2023 •
edited
Loading

…and document it

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested demo.rerun.io (if applicable)
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@emilk emilk added 📖 documentation Improvements or additions to documentation 🐍 Python API Python logging API include in changelog labels Oct 10, 2023
@teh-cmc teh-cmc self-requested a review October 10, 2023 12:44
@emilk @jleibs
Default to True
60e427e 
Co-authored-by: Jeremy Leibs <[email protected]>
teh-cmc
teh-cmc requested changes Oct 10, 2023
View reviewed changes
Copy link
Member

@teh-cmc teh-cmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should update the examples too to make use of the new default value.

rerun_py/rerun_sdk/rerun/components/disconnected_space_ext.py Outdated Show resolved Hide resolved
@emilk
Copy link
Member Author

emilk commented Oct 10, 2023

This should update the examples too to make use of the new default value.

Maybe? Then again, it is nice to demonstrate that there is a way to turn it off too. I went back and forth a bit.

@emilk emilk requested a review from teh-cmc October 10, 2023 13:08
@emilk emilk merged commit 5c1c3e2 into main Oct 10, 2023
30 checks passed
@emilk emilk deleted the emilk/disconnected-space branch October 10, 2023 20:02
@emilk emilk changed the title Document DisconnectedSpaces boolean Default DisconnectedSpaces boolean to true in Python Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jleibs jleibs jleibs approved these changes

@teh-cmc teh-cmc teh-cmc approved these changes

Assignees
No one assigned
Labels
📖 documentation Improvements or additions to documentation include in changelog 🐍 Python API Python logging API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DisconnectedSpace requires a parameter
3 participants
@emilk @teh-cmc @jleibs