Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DisconnectedSpace requires a parameter #3599

Closed
jleibs opened this issue Oct 2, 2023 · 0 comments · Fixed by #3760
Closed

DisconnectedSpace requires a parameter #3599

jleibs opened this issue Oct 2, 2023 · 0 comments · Fixed by #3760
Assignees
@emilk
Labels
😤 annoying Something in the UI / SDK is annoying to use 🐍 Python API Python logging API

Comments

@jleibs
Copy link
Member

jleibs commented Oct 2, 2023

There is currently a required boolean for disconnect space such that we have to log;

rr.DisconnectedSpace(True)

At a minimum we should provide a default value of True here but it's also unclear whether logging:

rr.DisconnectedSpace(False)

has the expected behavior.
@jleibs jleibs added 🐍 Python API Python logging API 😤 annoying Something in the UI / SDK is annoying to use labels Oct 2, 2023
@emilk emilk self-assigned this Oct 10, 2023
@emilk emilk changed the title Disconnected space requires a parameter. DisconnectedSpace requires a parameter Oct 10, 2023
@emilk emilk mentioned this issue Oct 10, 2023
Merged
4 tasks
emilk added a commit that referenced this issue Oct 10, 2023
@emilk @jleibs
Document DisconnectedSpaces boolean (#3760)
5c1c3e2 
…and default it to `True` in Python.

* Closes #3599

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/3760) (if
applicable)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/3760)
- [Docs
preview](https://rerun.io/preview/cecd2521e2e1a3affba182ee448f107ce40942ab/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/cecd2521e2e1a3affba182ee448f107ce40942ab/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://ref.rerun.io/dev/bench/)
- [Wasm size tracking](https://ref.rerun.io/dev/sizes/)

---------

Co-authored-by: Jeremy Leibs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emilk emilk

Labels
😤 annoying Something in the UI / SDK is annoying to use 🐍 Python API Python logging API
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Default DisconnectedSpaces boolean to true in Python rerun-io/rerun
2 participants
@emilk @jleibs