Only grow 3D view bounds with projected image if image plane has been user-edited #3749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleibs
changed the title
teh-cmc
approved these changes
Oct 10, 2023
emilk
reviewed
Oct 10, 2023
| // Only update the bounding box if the image_plane_distance is not auto. | ||
| // This is because in auto mode the bounds will change the image plane heuristic, | ||
| // and there's no good reason to grow the size of the bounds only to the shrink | ||
| // the image plane as a result. |
There was a problem hiding this comment.
More to the point: it causes a cyclic relationship, where the auto-distance depend on the bounding box, and the bounding box is affected by the distance
There was a problem hiding this comment.
It's only lightly cyclic though -- since net result is to shrink the plane it doesn't continue the cycle.
emilk
approved these changes
Oct 10, 2023
emilk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Resolves: #3728
Previously if just logging a pinhole, the projected image rectangle would cause the accumulated bounding box to increase, but then the heuristic would cause it to shrink again.
This changes that behavior to only happen in the event that the image plane has been user-edited (in which case the heuristic no longer applies). This gives us somewhat of the best of both worlds where the bounds can't impact themselves, but if a user increases them manually then the bounding box will still grow appropriately.
Before:
After:
Checklist