New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Images don't grow their bounds #3780

Closed

jleibs opened this issue Oct 10, 2023 · 0 comments · Fixed by #3784

Assignees

Labels

🪳 bug 🦟 regression

Milestone

Member

jleibs commented Oct 10, 2023 •

edited

Loading

#3749 introduced a regression on view bounds for images in 2D

Missed this failure mode on demo.rerun.io:
https://demo.rerun.io/pr/3749/examples/human_pose_tracking/

jleibs added 🪳 bug 🦟 regression labels

teh-cmc added this to the 0.9.1 milestone

jleibs mentioned this issue

Bugfix: still need to grow view bounds when the space view is 2D #3784

Merged

4 tasks

jleibs self-assigned this

jleibs closed this as completed in #3784

jleibs added a commit that referenced this issue


          Bugfix: still need to grow view bounds when the space view is 2D (#3784)

e021608

### What
Resolves: #3780

Whether we grow the view bounds based on an image depends on whether or
not it's a 2d or 3d space view. This wasn't available before and
required adding a bit of extra plumbing.

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/3784) (if
applicable)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/3784)
- [Docs
preview](https://rerun.io/preview/8367c1f82a01a9f0c5577a6a1b6642dcfff35e74/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/8367c1f82a01a9f0c5577a6a1b6642dcfff35e74/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://ref.rerun.io/dev/bench/)
- [Wasm size tracking](https://ref.rerun.io/dev/sizes/)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment