Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor rerun.AnyValues to handle None input more gracefully #3725

Merged
merged 9 commits into from
Oct 9, 2023
Merged

Refactor rerun.AnyValues to handle None input more gracefully #3725

merged 9 commits into from
Oct 9, 2023

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Oct 6, 2023 •
edited by github-actions bot
Loading

What

  • Rename _send_warning -> _send_warning_or_raise to make the behavior clearer.
  • Default to ignore Nones in AnyValues when the type is unknown.
  • Update the docstrings.
  • Expand the unit-tests.

Resolves:

Checklist

@jleibs jleibs marked this pull request as ready for review October 6, 2023 16:13
@jleibs jleibs added this to the 0.9.1 milestone Oct 6, 2023
abey79
abey79 approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@abey79 abey79 changed the title Refactor AnyValues to handle Nones more gracefully Refactor rerun.AnyValues to handle None` input more gracefully Oct 9, 2023
@abey79 abey79 merged commit 1a78cb7 into main Oct 9, 2023
31 checks passed
@abey79 abey79 deleted the jleibs/forgiving_any_values branch October 9, 2023 07:52
@abey79 abey79 mentioned this pull request Oct 9, 2023
Closed
@emilk emilk changed the title Refactor rerun.AnyValues to handle None` input more gracefully Refactor rerun.AnyValues to handle None input more gracefully Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abey79 abey79 abey79 approved these changes

Assignees
No one assigned
Labels
include in changelog 🐍 Python API Python logging API
Projects
None yet
Milestone
0.9.1
Development

Successfully merging this pull request may close these issues.
2 participants
@jleibs @abey79