Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AnyBatchValue double-raises in strict mode #3716

Closed
jleibs opened this issue Oct 5, 2023 · 1 comment
Closed

AnyBatchValue double-raises in strict mode #3716

jleibs opened this issue Oct 5, 2023 · 1 comment
Assignees
@jleibs
Labels
🪳 bug Something isn't working 🐍 Python API Python logging API
Milestone
0.9.1

Comments

@jleibs
Copy link
Member

jleibs commented Oct 5, 2023

We call send_warning, which raises an exception, which we attempt to catch and re-send, which in turn raises a new exception.

Very related to: #3715
@jleibs jleibs added the 🪳 bug Something isn't working label Oct 5, 2023
@jleibs jleibs added this to the 0.9.1 milestone Oct 5, 2023
@jleibs jleibs mentioned this issue Oct 6, 2023
Merged
3 tasks
@jleibs jleibs self-assigned this Oct 6, 2023
@emilk emilk added the 🐍 Python API Python logging API label Oct 9, 2023
abey79 pushed a commit that referenced this issue Oct 9, 2023
@jleibs
Refactor rerun.AnyValues to handle None` input more gracefully (#3725)
1a78cb7 
### What
- Rename `_send_warning` -> `_send_warning_or_raise` to make the
behavior clearer.
 - Default to ignore Nones in AnyValues when the type is unknown. 
 - Update the docstrings.
 - Expand the unit-tests.

Resolves:
 - #3715
 - #3716


### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/3725) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/3725)
- [Docs
preview](https://rerun.io/preview/5540cb4172d7bbef4749daf200ee14672af010e7/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/5540cb4172d7bbef4749daf200ee14672af010e7/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://ref.rerun.io/dev/bench/)
- [Wasm size tracking](https://ref.rerun.io/dev/sizes/)
@abey79
Copy link
Member

abey79 commented Oct 9, 2023

Fixed in #3725

@abey79 abey79 closed this as completed Oct 9, 2023
@jleibs jleibs mentioned this issue Oct 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jleibs jleibs

Labels
🪳 bug Something isn't working 🐍 Python API Python logging API
Projects
None yet
Milestone
0.9.1
Development

No branches or pull requests
3 participants
@emilk @jleibs @abey79