Allow showing image shaped tensors in the tensor view #3583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
added
enhancement
jleibs
approved these changes
Oct 2, 2023
3 tasks
emilk
added a commit
that referenced
this pull request
Oct 5, 2023
…root space view (#3681) ### What * Fixes #3677 Definitely need to come up with something better to steer the heuristics - we made good strides in space view refactor and recent advances in System heuristics, but there's still a lot to be desired! In the test scene there's still the issue of a unexplicably large accumulated bounding box which causes the camera to zoom out a lot. This is most likely caused by an initially bad heuristic for the frustum length. I suspect this is a problem we already had in 0.8 and might be fairly hard to solve until we fixup our blueprint & object property story. Before:  After:  Test code: ```py """Log a pinhole and a random image.""" import numpy as np import rerun as rr rr.init("rerun_example_pinhole", spawn=True) rng = np.random.default_rng(12345) image = rng.uniform(0, 255, size=[3, 3, 3]) rr.log("world/camera/image", rr.Pinhole(focal_length=3, width=3, height=3)) rr.log("world/camera/image", rr.Image(image)) image = rng.uniform(0, 255, size=[3, 3, 1]) rr.log("seg", rr.SegmentationImage(image)) ``` Also made sure this doesn't regress the fix in #3583 (which touched this code last!) ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/3681) (if applicable) - [PR Build Summary](https://build.rerun.io/pr/3681) - [Docs preview](https://rerun.io/preview/a29d7764be26c9cc746a726c589a284ef7efad8f/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/a29d7764be26c9cc746a726c589a284ef7efad8f/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://ref.rerun.io/dev/bench/) - [Wasm size tracking](https://ref.rerun.io/dev/sizes/) --------- Co-authored-by: Emil Ernerfeldt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
rr.Tensorwith image-like shape does not show in viewer #3569Testcode:
Before the
tensorentity wouldn't show anything, now this shows two space views:In fact, we didn't allow tensor views for anything image shaped at all before!
Tested with
python ./scripts/run_all.py --fastand (todo!) webdemo that this didn't break heuristicChecklist