-
Notifications
You must be signed in to change notification settings - Fork 373
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix presence of segmentation images and tensor causing generation of …
…root space view (#3681) ### What * Fixes #3677 Definitely need to come up with something better to steer the heuristics - we made good strides in space view refactor and recent advances in System heuristics, but there's still a lot to be desired! In the test scene there's still the issue of a unexplicably large accumulated bounding box which causes the camera to zoom out a lot. This is most likely caused by an initially bad heuristic for the frustum length. I suspect this is a problem we already had in 0.8 and might be fairly hard to solve until we fixup our blueprint & object property story. Before: ![image](https://github.com/rerun-io/rerun/assets/1220815/fa3e3867-aa52-47da-b0a9-83eae9436429) After: ![image](https://github.com/rerun-io/rerun/assets/1220815/2dd20446-bc68-4c22-99ab-0465f64262dc) Test code: ```py """Log a pinhole and a random image.""" import numpy as np import rerun as rr rr.init("rerun_example_pinhole", spawn=True) rng = np.random.default_rng(12345) image = rng.uniform(0, 255, size=[3, 3, 3]) rr.log("world/camera/image", rr.Pinhole(focal_length=3, width=3, height=3)) rr.log("world/camera/image", rr.Image(image)) image = rng.uniform(0, 255, size=[3, 3, 1]) rr.log("seg", rr.SegmentationImage(image)) ``` Also made sure this doesn't regress the fix in #3583 (which touched this code last!) ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/3681) (if applicable) - [PR Build Summary](https://build.rerun.io/pr/3681) - [Docs preview](https://rerun.io/preview/a29d7764be26c9cc746a726c589a284ef7efad8f/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/a29d7764be26c9cc746a726c589a284ef7efad8f/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://ref.rerun.io/dev/bench/) - [Wasm size tracking](https://ref.rerun.io/dev/sizes/) --------- Co-authored-by: Emil Ernerfeldt <[email protected]>
- Loading branch information
Showing
7 changed files
with
29 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters