Make FileSink actually flush its data when asked to
#3525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
teh-cmc
added a commit
that referenced
this pull request
Sep 29, 2023
Everything to seamlessly integrate `TextLog` with native loggers in Python & Rust. - [How-to guide](https://www.rerun.io/preview/154a8a0873def8fbdadc50805778aff2458f08b7/docs/howto/integration-with-native-logger) - Requires #3525 - Fixes #3450
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FileSinkcurrently ignores flushing requests, which leads to very hard to track down issues where data is silently dropped even though you're really really trying very hard to flush that dang RecordingStream.TextLogintegrations with native loggers #3522What
Checklist