TextLog integrations with native loggers
#3522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teh-cmc
added
📖 documentation
teh-cmc
commented
Sep 28, 2023
teh-cmc
force-pushed
the
cmc/logging_logs
branch
from
154a8a0 to
5da01af
Compare
3 tasks
teh-cmc
force-pushed
the
cmc/logging_logs
branch
from
9bfd781 to
a4aaa67
Compare
teh-cmc
added a commit
that referenced
this pull request
Sep 28, 2023
`FileSink` currently ignores flushing requests, which leads to [very hard to track down issues where data is silently dropped even though you're really really trying very hard to flush that dang RecordingStream](#3522 (comment)). - Unblocks #3522
This reverts commit a8fa8c1.
teh-cmc
force-pushed
the
cmc/logging_logs
branch
from
a4aaa67 to
2efc524
Compare
Wumpf
approved these changes
Sep 29, 2023
| """ Designates very low priority, often extremely verbose, information. """ | ||
|
|
||
| @staticmethod | ||
| def deferred_patch_class(cls: Any) -> None: |
There was a problem hiding this comment.
is it somehow guaranteed that this runs before other classes are initialized? In particular I'm concerned that LoggingHandler's LVL2NAME dictionary may still read the none values, not the strings
There was a problem hiding this comment.
deferred_patch_class is called as part of the global import scope, so it should be guaranteed as far as I know yes.
emilk
reviewed
Sep 29, 2023
| log::Level::Debug => TextLogLevel::DEBUG, | ||
| log::Level::Trace => TextLogLevel::TRACE, | ||
| } | ||
| .into() |
There was a problem hiding this comment.
TextLogLevel::TRACE & friends are actually &strs because TextLogLevel isn't const
teh-cmc
commented
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything to seamlessly integrate
TextLogwith native loggers in Python & Rust.How-to guide
Requires Make
FileSinkactually flush its data when asked to #3525Fixes
TextLogintegration with native logging tools #3450Checklist