Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The new link format is
https://static.rerun.io/{original_image_name_minus_extension}/{content_hash}/{width}.{ext}
For example,
https://static.rerun.io/ae4b8970edba8480431cb71e57b8cddd9e1769c7_clock_480w.png
is nowhttps://static.rerun.io/clock/ae4b8970edba8480431cb71e57b8cddd9e1769c7/480w.png
.What makes this more discoverable:
updated at
date of each hash to find the latest one.upload_image.py
has been updated to use the new format. We're nowhere near the point of using too much space on GCS, so all the old links are preserved.This PR also fixes some other issues:
thumbnails.py
did not handle updatingthumbnail_dimensions
correctly if the property was already present in the frontmatterupload_image.py
would fail if the user does not havedelete
permission when uploading the same image twice, because it would attempt to overwrite the existing image. if the content hash does not change, then we do not need to upload the image again, so we just skip uploading to GCS if the object already exists.Checklist