-
Notifications
You must be signed in to change notification settings - Fork 373
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
### What * Fixes #2461 The new link format is `https://static.rerun.io/{original_image_name_minus_extension}/{content_hash}/{width}.{ext}` For example, `https://static.rerun.io/ae4b8970edba8480431cb71e57b8cddd9e1769c7_clock_480w.png` is now `https://static.rerun.io/clock/ae4b8970edba8480431cb71e57b8cddd9e1769c7/480w.png`. What makes this more discoverable: - For machines, it's the fact that the hash is the same for all sizes. This means given an image URL, you can retrieve all the other sizes. This is important for #3445. - For humans, the top-level directory is the name of the image, which makes it _much_ easier to browse through GCS looking for that image. You can compare the `updated at` date of each hash to find the latest one. `upload_image.py` has been updated to use the new format. We're nowhere near the point of using too much space on GCS, so all the old links are preserved. This PR also fixes some other issues: - `thumbnails.py` did not handle updating `thumbnail_dimensions` correctly if the property was already present in the frontmatter - `upload_image.py` would fail if the user does not have `delete` permission when uploading the same image twice, because it would attempt to overwrite the existing image. if the content hash does not change, then we do not need to upload the image again, so we just skip uploading to GCS if the object already exists. ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/3477) (if applicable) - [PR Build Summary](https://build.rerun.io/pr/3477) - [Docs preview](https://rerun.io/preview/67a25d43432ddf6245f04ca52806fd976a4dac4e/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/67a25d43432ddf6245f04ca52806fd976a4dac4e/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://ref.rerun.io/dev/bench/) - [Wasm size tracking](https://ref.rerun.io/dev/sizes/)
- Loading branch information
Showing
71 changed files
with
591 additions
and
569 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.