Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep track of how files are sourced for analytics and UI #3371

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Keep track of how files are sourced for analytics and UI #3371

merged 2 commits into from
Sep 20, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented Sep 19, 2023 •
edited
Loading 

pub enum FileSource {
    Cli,
    DragAndDrop,
    FileDialog,
}

Checklist

@emilk
Keep track of how files where sources for analytics and UI
bd47b69 
```
pub enum FileSource {
    Cli,
    DragAndDrop,
    FileDialog,
}
```
@emilk emilk added the 📊 analytics telemetry analytics label Sep 19, 2023
@Wumpf Wumpf self-requested a review September 19, 2023 16:22
Wumpf
Wumpf approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
some of the code paths are still a bit hard to follow (what version is what, why are certain cases possible/not possible etc.), but definitely an improvement on that front as well!

@emilk emilk merged commit 46e4132 into main Sep 20, 2023
@emilk emilk deleted the emilk/file-sources branch September 20, 2023 06:35
@emilk emilk changed the title Keep track of how files where sources for analytics and UI Keep track of how files where sourced for analytics and UI Sep 20, 2023
@emilk emilk changed the title Keep track of how files where sourced for analytics and UI Keep track of how files are sourced for analytics and UI Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
📊 analytics telemetry analytics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Opening non-rrd files through the UI should be reflected in the StoreSource
2 participants
@emilk @Wumpf