Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening non-rrd files through the UI should be reflected in the StoreSource #3272

Closed
teh-cmc opened this issue Sep 11, 2023 · 0 comments · Fixed by #3371
Closed

Opening non-rrd files through the UI should be reflected in the StoreSource #3272

teh-cmc opened this issue Sep 11, 2023 · 0 comments · Fixed by #3371
Labels
📊 analytics telemetry analytics 🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself

Comments

@teh-cmc
Copy link
Member

teh-cmc commented Sep 11, 2023

By allowing users to drag-and-drop/open non-rrd files in the UI, we've effectively introduced a new logging source (where logging source is broadly defined as creating a store), but we haven't reflected that in the StoreSource enum:

pub enum StoreSource {
    Unknown,

    /// The official Rerun C Logging SDK
    CSdk,

    /// The official Rerun Python Logging SDK
    PythonSdk(PythonVersion),

    /// The official Rerun Rust Logging SDK
    RustSdk {
        rustc_version: String,
        llvm_version: String,
    },

    /// Loading a file directly from disk via the CLI.
    FileFromCli {
        rustc_version: String,
        llvm_version: String,
    },

    /// Perhaps from some manual data ingestion?
    Other(String),
}

We're missing a FileFromUI entry:

    /// Loading a file directly from the UI (open or drag-and-drop).
    ///
    /// Only relevant for non-rrd files.
    FileFromUi {
        viewer_version: String,
    },

Loading a jpeg through the UI should resulting in store_source=FileFromUi and data_source=File.

@teh-cmc teh-cmc added 📺 re_viewer affects re_viewer itself 📊 analytics telemetry analytics labels Sep 11, 2023
@emilk emilk added the 🪳 bug Something isn't working label Sep 11, 2023
@emilk emilk self-assigned this Sep 19, 2023
emilk added a commit that referenced this issue Sep 20, 2023
* Closes #3272

```
pub enum FileSource {
    Cli,
    DragAndDrop,
    FileDialog,
}
```

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/3371) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/3371)
- [Docs
preview](https://rerun.io/preview/460a3460e72914df330f4e3b0c2c517f740bd9fe/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/460a3460e72914df330f4e3b0c2c517f740bd9fe/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://ref.rerun.io/dev/bench/)
- [Wasm size tracking](https://ref.rerun.io/dev/sizes/)
@emilk emilk removed their assignment Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📊 analytics telemetry analytics 🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants