Improve error message in common re_renderer crash
#3070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
changed the title
re_renderer crash
emilk
added
🔺 re_renderer
Size changes
|
emilk
changed the title
re_renderer crashre_renderer crash
jleibs
pushed a commit
that referenced
this pull request
Aug 31, 2023
Here is a reproduce:
```diff
--- a/examples/rust/clock/src/main.rs
+++ b/examples/rust/clock/src/main.rs
@@ -77,7 +77,7 @@ fn run(rec_stream: &RecordingStream, args: &Args) -> anyhow::Result<()> {
.with_component(&[color])?
.send(rec_stream)?;
MsgSender::new(format!("world/{name}_hand"))
- .with_component(&[Vector3D::from(pos)])?
+ .with_component(&[Vector3D::from(pos); 65537])?
.with_component(&[color])?
.with_component(&[Radius(width * 0.5)])?
.send(rec_stream)?;
```
We are hitting `LineDrawData::MAX_NUM_STRIPS`.
It's really bad if it is the case that hitting an upper limit crashes
the viewer 😭
----
In 0.8.1 we have 21 users crashing in
`re_renderer-0.8.0/src/allocator/cpu_write_gpu_read_belt.rs:87`
Callstack:
```
8: <re_renderer::line_strip_builder::LineStripBuilder as core::ops::drop::Drop>::drop
9: re_space_view_spatial::parts::arrows3d::Arrows3DPart::process_entity_view
10: re_space_view_spatial::parts::entity_iterator::process_entity_views
11: <re_space_view_spatial::parts::arrows3d::Arrows3DPart as re_viewer_context::space_view::view_part_system::ViewPartSystem>::execute
12: re_viewer_context::space_view::space_view_class::<impl re_viewer_context::space_view::dyn_space_view_class::DynSpaceViewClass for T>::ui
13: core::ops::function::FnOnce::call_once{{vtable.shim}}
```
`Arrows3DPart` is using `LineBatchBuilder`.
`LineBatchBuilder::add_segment` returns a `LineStripBuilder`
`LineStripBuilder::drop` calls `CpuWriteGpuReadBuffer::extend` which
calls
`CpuWriteGpuReadBuffer::push` which crashes because the
`CpuWriteGpuReadBuffer` is full
### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/{{
pr.number }}) (if applicable)
- [PR Build Summary](https://build.rerun.io/pr/{{ pr.number }})
- [Docs preview](https://rerun.io/preview/{{
"pr:%s"|format(pr.branch)|encode_uri_component }}/docs)
- [Examples preview](https://rerun.io/preview/{{
"pr:%s"|format(pr.branch)|encode_uri_component }}/examples)
- [Recent benchmark results](https://ref.rerun.io/dev/bench/)
- [Wasm size tracking](https://ref.rerun.io/dev/sizes/)
jleibs
pushed a commit
that referenced
this pull request
Aug 31, 2023
Here is a reproduce:
```diff
--- a/examples/rust/clock/src/main.rs
+++ b/examples/rust/clock/src/main.rs
@@ -77,7 +77,7 @@ fn run(rec_stream: &RecordingStream, args: &Args) -> anyhow::Result<()> {
.with_component(&[color])?
.send(rec_stream)?;
MsgSender::new(format!("world/{name}_hand"))
- .with_component(&[Vector3D::from(pos)])?
+ .with_component(&[Vector3D::from(pos); 65537])?
.with_component(&[color])?
.with_component(&[Radius(width * 0.5)])?
.send(rec_stream)?;
```
We are hitting `LineDrawData::MAX_NUM_STRIPS`.
It's really bad if it is the case that hitting an upper limit crashes
the viewer 😭
----
In 0.8.1 we have 21 users crashing in
`re_renderer-0.8.0/src/allocator/cpu_write_gpu_read_belt.rs:87`
Callstack:
```
8: <re_renderer::line_strip_builder::LineStripBuilder as core::ops::drop::Drop>::drop
9: re_space_view_spatial::parts::arrows3d::Arrows3DPart::process_entity_view
10: re_space_view_spatial::parts::entity_iterator::process_entity_views
11: <re_space_view_spatial::parts::arrows3d::Arrows3DPart as re_viewer_context::space_view::view_part_system::ViewPartSystem>::execute
12: re_viewer_context::space_view::space_view_class::<impl re_viewer_context::space_view::dyn_space_view_class::DynSpaceViewClass for T>::ui
13: core::ops::function::FnOnce::call_once{{vtable.shim}}
```
`Arrows3DPart` is using `LineBatchBuilder`.
`LineBatchBuilder::add_segment` returns a `LineStripBuilder`
`LineStripBuilder::drop` calls `CpuWriteGpuReadBuffer::extend` which
calls
`CpuWriteGpuReadBuffer::push` which crashes because the
`CpuWriteGpuReadBuffer` is full
### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/{{
pr.number }}) (if applicable)
- [PR Build Summary](https://build.rerun.io/pr/{{ pr.number }})
- [Docs preview](https://rerun.io/preview/{{
"pr:%s"|format(pr.branch)|encode_uri_component }}/docs)
- [Examples preview](https://rerun.io/preview/{{
"pr:%s"|format(pr.branch)|encode_uri_component }}/examples)
- [Recent benchmark results](https://ref.rerun.io/dev/bench/)
- [Wasm size tracking](https://ref.rerun.io/dev/sizes/)
jleibs
pushed a commit
that referenced
this pull request
Aug 31, 2023
Here is a reproduce:
```diff
--- a/examples/rust/clock/src/main.rs
+++ b/examples/rust/clock/src/main.rs
@@ -77,7 +77,7 @@ fn run(rec_stream: &RecordingStream, args: &Args) -> anyhow::Result<()> {
.with_component(&[color])?
.send(rec_stream)?;
MsgSender::new(format!("world/{name}_hand"))
- .with_component(&[Vector3D::from(pos)])?
+ .with_component(&[Vector3D::from(pos); 65537])?
.with_component(&[color])?
.with_component(&[Radius(width * 0.5)])?
.send(rec_stream)?;
```
We are hitting `LineDrawData::MAX_NUM_STRIPS`.
It's really bad if it is the case that hitting an upper limit crashes
the viewer 😭
----
In 0.8.1 we have 21 users crashing in
`re_renderer-0.8.0/src/allocator/cpu_write_gpu_read_belt.rs:87`
Callstack:
```
8: <re_renderer::line_strip_builder::LineStripBuilder as core::ops::drop::Drop>::drop
9: re_space_view_spatial::parts::arrows3d::Arrows3DPart::process_entity_view
10: re_space_view_spatial::parts::entity_iterator::process_entity_views
11: <re_space_view_spatial::parts::arrows3d::Arrows3DPart as re_viewer_context::space_view::view_part_system::ViewPartSystem>::execute
12: re_viewer_context::space_view::space_view_class::<impl re_viewer_context::space_view::dyn_space_view_class::DynSpaceViewClass for T>::ui
13: core::ops::function::FnOnce::call_once{{vtable.shim}}
```
`Arrows3DPart` is using `LineBatchBuilder`.
`LineBatchBuilder::add_segment` returns a `LineStripBuilder`
`LineStripBuilder::drop` calls `CpuWriteGpuReadBuffer::extend` which
calls
`CpuWriteGpuReadBuffer::push` which crashes because the
`CpuWriteGpuReadBuffer` is full
### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/{{
pr.number }}) (if applicable)
- [PR Build Summary](https://build.rerun.io/pr/{{ pr.number }})
- [Docs preview](https://rerun.io/preview/{{
"pr:%s"|format(pr.branch)|encode_uri_component }}/docs)
- [Examples preview](https://rerun.io/preview/{{
"pr:%s"|format(pr.branch)|encode_uri_component }}/examples)
- [Recent benchmark results](https://ref.rerun.io/dev/bench/)
- [Wasm size tracking](https://ref.rerun.io/dev/sizes/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a reproduce:
We are hitting
LineDrawData::MAX_NUM_STRIPS.It's really bad if it is the case that hitting an upper limit crashes the viewer 😭
In 0.8.1 we have 21 users crashing in
re_renderer-0.8.0/src/allocator/cpu_write_gpu_read_belt.rs:87Callstack:
Arrows3DPartis usingLineBatchBuilder.LineBatchBuilder::add_segmentreturns aLineStripBuilderLineStripBuilder::dropcallsCpuWriteGpuReadBuffer::extendwhich callsCpuWriteGpuReadBuffer::pushwhich crashes because theCpuWriteGpuReadBufferis fullChecklist