Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash when reaching maximum number of linestrips #3075

Closed
Wumpf opened this issue Aug 22, 2023 · 0 comments · Fixed by #3093
Closed

Crash when reaching maximum number of linestrips #3075

Wumpf opened this issue Aug 22, 2023 · 0 comments · Fixed by #3093
Labels
🪳 bug Something isn't working 💣 crash crash, deadlock/freeze, do-no-start 🔺 re_renderer affects re_renderer itself
Milestone
0.8.2

Comments

@Wumpf
Copy link
Member

Wumpf commented Aug 22, 2023 •
edited
Loading

We're crashing right now when reaching the maximum number of linestrips.
There's likely similar cases still around - I remember fixing this for points in the past; should do a sweep over all of them, can we add a unit tests for this?

The penultimate fix for this is not having these limits in the first place which is a long standing issue #3076
@Wumpf Wumpf added 🪳 bug Something isn't working 🔺 re_renderer affects re_renderer itself 💣 crash crash, deadlock/freeze, do-no-start labels Aug 22, 2023
@Wumpf Wumpf added this to the 0.9 milestone Aug 22, 2023
@emilk emilk modified the milestones: 0.9, 0.8.2 Aug 23, 2023
@Wumpf Wumpf mentioned this issue Aug 24, 2023
Merged
3 tasks
Wumpf added a commit that referenced this issue Aug 25, 2023
@Wumpf
Fix crash on reaching line number limit (#3093)
c2c982a 
### What

* Fixes: #3075
* Related to: #3076

The second commit is the actual fix. But to avoid this family of
crashes, the cpuwritegpuread belt now always does error checks and
returns errors instead of paniking

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/3093) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/3093)
- [Docs
preview](https://rerun.io/preview/b6b737939d3219b0ca32e763d7276b5ca0d504ee/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/b6b737939d3219b0ca32e763d7276b5ca0d504ee/examples)
<!--EXAMPLES-PREVIEW--><!--EXAMPLES-PREVIEW--><!--EXAMPLES-PREVIEW--><!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://ref.rerun.io/dev/bench/)
- [Wasm size tracking](https://ref.rerun.io/dev/sizes/)
jleibs pushed a commit that referenced this issue Aug 31, 2023
@Wumpf @jleibs
Fix crash on reaching line number limit (#3093)
6f535e8 
* Fixes: #3075
* Related to: #3076

The second commit is the actual fix. But to avoid this family of
crashes, the cpuwritegpuread belt now always does error checks and
returns errors instead of paniking

* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/3093) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/3093)
- [Docs
preview](https://rerun.io/preview/b6b737939d3219b0ca32e763d7276b5ca0d504ee/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/b6b737939d3219b0ca32e763d7276b5ca0d504ee/examples)
<!--EXAMPLES-PREVIEW--><!--EXAMPLES-PREVIEW--><!--EXAMPLES-PREVIEW--><!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://ref.rerun.io/dev/bench/)
- [Wasm size tracking](https://ref.rerun.io/dev/sizes/)
jleibs pushed a commit that referenced this issue Aug 31, 2023
@Wumpf @jleibs
Fix crash on reaching line number limit (#3093)
98bd1f5 
* Fixes: #3075
* Related to: #3076

The second commit is the actual fix. But to avoid this family of
crashes, the cpuwritegpuread belt now always does error checks and
returns errors instead of paniking

* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/3093) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/3093)
- [Docs
preview](https://rerun.io/preview/b6b737939d3219b0ca32e763d7276b5ca0d504ee/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/b6b737939d3219b0ca32e763d7276b5ca0d504ee/examples)
<!--EXAMPLES-PREVIEW--><!--EXAMPLES-PREVIEW--><!--EXAMPLES-PREVIEW--><!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://ref.rerun.io/dev/bench/)
- [Wasm size tracking](https://ref.rerun.io/dev/sizes/)
jleibs pushed a commit that referenced this issue Aug 31, 2023
@Wumpf @jleibs
Fix crash on reaching line number limit (#3093)
c11fbf1 
* Fixes: #3075
* Related to: #3076

The second commit is the actual fix. But to avoid this family of
crashes, the cpuwritegpuread belt now always does error checks and
returns errors instead of paniking

* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/3093) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/3093)
- [Docs
preview](https://rerun.io/preview/b6b737939d3219b0ca32e763d7276b5ca0d504ee/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/b6b737939d3219b0ca32e763d7276b5ca0d504ee/examples)
<!--EXAMPLES-PREVIEW--><!--EXAMPLES-PREVIEW--><!--EXAMPLES-PREVIEW--><!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://ref.rerun.io/dev/bench/)
- [Wasm size tracking](https://ref.rerun.io/dev/sizes/)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🪳 bug Something isn't working 💣 crash crash, deadlock/freeze, do-no-start 🔺 re_renderer affects re_renderer itself
Projects
None yet
Milestone
0.8.2
Development

Successfully merging a pull request may close this issue.

Fix crash when trying to render too many line segments rerun-io/rerun
2 participants
@emilk @Wumpf