Change the "slow-down-camera" modifier to Alt on non-Mac #3051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h3mosphere
force-pushed
the
slow-down-is-alt-on-non-macos
branch
from
c43092a to
9b47c4d
Compare
|
Thanks for the PR! It is desirable to keep the same shortcuts natively as on the browser on the same computer. To that end we would need to change the compile-time switch in this PR to a runtime switch. You can use |
emilk
changed the title
|
OK, that was easy enough. There are some new problems with both Alt-E, and Ctrl-E being captured by the browser, but native is probably more important (it is to me anyway), and this problem exists regardless (current behaviour is broken with Ctrl-E in chrome on linux). This also updates the help text, in which the displayed modifiers were reversed to what they actually are. |
…ime what camera movement slow down modifier key. This presents new problems with Alt-E being a browser shortcut in chrome to bring up the main menu, but so also is Ctrl-E being focus the url bar.
h3mosphere
force-pushed
the
slow-down-is-alt-on-non-macos
branch
from
8891177 to
1b599ef
Compare
emilk
approved these changes
Aug 22, 2023
|
Anything missing before we get this in, meaning getting it out of draft? |
|
|
jleibs
pushed a commit
that referenced
this pull request
Aug 31, 2023
This Fixes #1867. Setting Alt as the slowdown behaviour for the camera movement. Note, that this also sets it to alt for wasm architecture, let me know if you wish for an extra check for wasm (and leave it as alt). Thanks. * [X] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [X] I've included a screenshot or gif (if applicable) * [X] I have tested [demo.rerun.io](https://demo.rerun.io/pr/{{ pr.number }}) (if applicable) - [PR Build Summary](https://build.rerun.io/pr/{{ pr.number }}) - [Docs preview](https://rerun.io/preview/{{ "pr:%s"|format(pr.branch)|encode_uri_component }}/docs) - [Examples preview](https://rerun.io/preview/{{ "pr:%s"|format(pr.branch)|encode_uri_component }}/examples) - [Recent benchmark results](https://ref.rerun.io/dev/bench/) - [Wasm size tracking](https://ref.rerun.io/dev/sizes/) --------- Co-authored-by: hemosphere <[email protected]> Co-authored-by: Emil Ernerfeldt <[email protected]>
jleibs
pushed a commit
that referenced
this pull request
Aug 31, 2023
This Fixes #1867. Setting Alt as the slowdown behaviour for the camera movement. Note, that this also sets it to alt for wasm architecture, let me know if you wish for an extra check for wasm (and leave it as alt). Thanks. * [X] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [X] I've included a screenshot or gif (if applicable) * [X] I have tested [demo.rerun.io](https://demo.rerun.io/pr/{{ pr.number }}) (if applicable) - [PR Build Summary](https://build.rerun.io/pr/{{ pr.number }}) - [Docs preview](https://rerun.io/preview/{{ "pr:%s"|format(pr.branch)|encode_uri_component }}/docs) - [Examples preview](https://rerun.io/preview/{{ "pr:%s"|format(pr.branch)|encode_uri_component }}/examples) - [Recent benchmark results](https://ref.rerun.io/dev/bench/) - [Wasm size tracking](https://ref.rerun.io/dev/sizes/) --------- Co-authored-by: hemosphere <[email protected]> Co-authored-by: Emil Ernerfeldt <[email protected]>
jleibs
pushed a commit
that referenced
this pull request
Aug 31, 2023
This Fixes #1867. Setting Alt as the slowdown behaviour for the camera movement. Note, that this also sets it to alt for wasm architecture, let me know if you wish for an extra check for wasm (and leave it as alt). Thanks. * [X] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [X] I've included a screenshot or gif (if applicable) * [X] I have tested [demo.rerun.io](https://demo.rerun.io/pr/{{ pr.number }}) (if applicable) - [PR Build Summary](https://build.rerun.io/pr/{{ pr.number }}) - [Docs preview](https://rerun.io/preview/{{ "pr:%s"|format(pr.branch)|encode_uri_component }}/docs) - [Examples preview](https://rerun.io/preview/{{ "pr:%s"|format(pr.branch)|encode_uri_component }}/examples) - [Recent benchmark results](https://ref.rerun.io/dev/bench/) - [Wasm size tracking](https://ref.rerun.io/dev/sizes/) --------- Co-authored-by: hemosphere <[email protected]> Co-authored-by: Emil Ernerfeldt <[email protected]>
jleibs
pushed a commit
that referenced
this pull request
Aug 31, 2023
This Fixes #1867. Setting Alt as the slowdown behaviour for the camera movement. Note, that this also sets it to alt for wasm architecture, let me know if you wish for an extra check for wasm (and leave it as alt). Thanks. * [X] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [X] I've included a screenshot or gif (if applicable) * [X] I have tested [demo.rerun.io](https://demo.rerun.io/pr/{{ pr.number }}) (if applicable) - [PR Build Summary](https://build.rerun.io/pr/{{ pr.number }}) - [Docs preview](https://rerun.io/preview/{{ "pr:%s"|format(pr.branch)|encode_uri_component }}/docs) - [Examples preview](https://rerun.io/preview/{{ "pr:%s"|format(pr.branch)|encode_uri_component }}/examples) - [Recent benchmark results](https://ref.rerun.io/dev/bench/) - [Wasm size tracking](https://ref.rerun.io/dev/sizes/) --------- Co-authored-by: hemosphere <[email protected]> Co-authored-by: Emil Ernerfeldt <[email protected]>
jleibs
pushed a commit
that referenced
this pull request
Aug 31, 2023
This Fixes #1867. Setting Alt as the slowdown behaviour for the camera movement. Note, that this also sets it to alt for wasm architecture, let me know if you wish for an extra check for wasm (and leave it as alt). Thanks. * [X] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [X] I've included a screenshot or gif (if applicable) * [X] I have tested [demo.rerun.io](https://demo.rerun.io/pr/{{ pr.number }}) (if applicable) - [PR Build Summary](https://build.rerun.io/pr/{{ pr.number }}) - [Docs preview](https://rerun.io/preview/{{ "pr:%s"|format(pr.branch)|encode_uri_component }}/docs) - [Examples preview](https://rerun.io/preview/{{ "pr:%s"|format(pr.branch)|encode_uri_component }}/examples) - [Recent benchmark results](https://ref.rerun.io/dev/bench/) - [Wasm size tracking](https://ref.rerun.io/dev/sizes/) --------- Co-authored-by: hemosphere <[email protected]> Co-authored-by: Emil Ernerfeldt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Fixes #1867. Setting Alt as the slowdown behaviour for the camera movement. Note, that this also sets it to alt for wasm architecture, let me know if you wish for an extra check for wasm (and leave it as alt).
Thanks.
What
Checklist