Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using WASD+EQ with Ctrl Modifier results in program exit & save file. #1867

Closed
h3mosphere opened this issue Apr 16, 2023 · 2 comments · Fixed by #3051
Closed

Using WASD+EQ with Ctrl Modifier results in program exit & save file. #1867

h3mosphere opened this issue Apr 16, 2023 · 2 comments · Fixed by #3051
Labels
😤 annoying Something in the UI / SDK is annoying to use 🪳 bug Something isn't working good first issue Good for newcomers 🏎️ Quick Issue Can be fixed in a few hours or less ui concerns graphical user interface

Comments

@h3mosphere
Copy link
Contributor

h3mosphere commented Apr 16, 2023

It seems that using the WASDEQ keys, for moving around the 3d view, the speed can be modified via Ctrl|Shift|Alt. This is nice, however it appears to clash with application level keyboard shortcuts: Ctrl-Q, and Ctrl-S.

To Reproduce
Steps to reproduce the behavior:

  1. Press Ctrl-Q or Ctrl-S, expecting fine movement in the Y-Up, or Z-Back direction.
  2. The application quits, or pops up a save dialog.

Expected behavior

  1. Maybe remove the application level key bindings. Needing to quit the application, and save, come up alot less frequently than fine-level control of camera, for certain data sets.
  2. Have Shift + WASDEQ be the fine-level movement, instead of control. Perhaps even removing Control entirely. Currently Shift moves very fast, for a dataset which is 70m+ in the X+Z directions, the dataset flies out of the view very easily.

Your goals
Move around the dataset to get a view from a particular point, needing quite fine level control over movement.

Desktop (please complete the following information):

  • OS: Linux Ubuntu 22.10
@h3mosphere h3mosphere added 👀 needs triage This issue needs to be triaged by the Rerun team 😤 annoying Something in the UI / SDK is annoying to use labels Apr 16, 2023
@Wumpf
Copy link
Member

Wumpf commented Apr 16, 2023

Thanks for filing this!
(For all Mac users out there: You don't run into this problem because saving is via Cmd for you!)

imho neither removing the shortcuts nor removing the slow-down is great:

  • application wide shortcuts at least for saving are so common, they are expected to work
  • speed plus slowdown are useful to quickly support variety of scenes. But we may need to tweak the factors & expose camera speed etc. as a user setting on the space views

With that stance the only way out is a different button for slowdown. Proposing to stick with Ctrl on Mac and use Alt on Windows & Linux. What do you think?

@Wumpf Wumpf added 🪳 bug Something isn't working good first issue Good for newcomers and removed 👀 needs triage This issue needs to be triaged by the Rerun team labels Apr 16, 2023
@h3mosphere
Copy link
Contributor Author

h3mosphere commented Apr 17, 2023

Whichever seems most appropriate. Thinking about it now, it is probably best to stay away from CTRL as it is used most often with key combos that users will be familiar with.

Alt may already be bound to a speed 'mode'. I'll have a look at the the code see what the combinations are currently.

Probably for someone else to weigh in here on what is correct/blessed.

Thanks

@emilk emilk added 🏎️ Quick Issue Can be fixed in a few hours or less ui concerns graphical user interface labels Apr 26, 2023
emilk added a commit that referenced this issue Aug 31, 2023
This Fixes #1867. Setting Alt as the slowdown behaviour for the camera
movement. Note, that this also sets it to alt for wasm architecture, let
me know if you wish for an extra check for wasm (and leave it as alt).

Thanks.

### What

### Checklist
* [X] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [X] I've included a screenshot or gif (if applicable)
* [X] I have tested [demo.rerun.io](https://demo.rerun.io/pr/{{
pr.number }}) (if applicable)

- [PR Build Summary](https://build.rerun.io/pr/{{ pr.number }})
- [Docs preview](https://rerun.io/preview/{{
"pr:%s"|format(pr.branch)|encode_uri_component }}/docs)
- [Examples preview](https://rerun.io/preview/{{
"pr:%s"|format(pr.branch)|encode_uri_component }}/examples)
- [Recent benchmark results](https://ref.rerun.io/dev/bench/)
- [Wasm size tracking](https://ref.rerun.io/dev/sizes/)

---------

Co-authored-by: hemosphere <[email protected]>
Co-authored-by: Emil Ernerfeldt <[email protected]>
jleibs pushed a commit that referenced this issue Aug 31, 2023
This Fixes #1867. Setting Alt as the slowdown behaviour for the camera
movement. Note, that this also sets it to alt for wasm architecture, let
me know if you wish for an extra check for wasm (and leave it as alt).

Thanks.

* [X] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [X] I've included a screenshot or gif (if applicable)
* [X] I have tested [demo.rerun.io](https://demo.rerun.io/pr/{{
pr.number }}) (if applicable)

- [PR Build Summary](https://build.rerun.io/pr/{{ pr.number }})
- [Docs preview](https://rerun.io/preview/{{
"pr:%s"|format(pr.branch)|encode_uri_component }}/docs)
- [Examples preview](https://rerun.io/preview/{{
"pr:%s"|format(pr.branch)|encode_uri_component }}/examples)
- [Recent benchmark results](https://ref.rerun.io/dev/bench/)
- [Wasm size tracking](https://ref.rerun.io/dev/sizes/)

---------

Co-authored-by: hemosphere <[email protected]>
Co-authored-by: Emil Ernerfeldt <[email protected]>
jleibs pushed a commit that referenced this issue Aug 31, 2023
This Fixes #1867. Setting Alt as the slowdown behaviour for the camera
movement. Note, that this also sets it to alt for wasm architecture, let
me know if you wish for an extra check for wasm (and leave it as alt).

Thanks.

* [X] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [X] I've included a screenshot or gif (if applicable)
* [X] I have tested [demo.rerun.io](https://demo.rerun.io/pr/{{
pr.number }}) (if applicable)

- [PR Build Summary](https://build.rerun.io/pr/{{ pr.number }})
- [Docs preview](https://rerun.io/preview/{{
"pr:%s"|format(pr.branch)|encode_uri_component }}/docs)
- [Examples preview](https://rerun.io/preview/{{
"pr:%s"|format(pr.branch)|encode_uri_component }}/examples)
- [Recent benchmark results](https://ref.rerun.io/dev/bench/)
- [Wasm size tracking](https://ref.rerun.io/dev/sizes/)

---------

Co-authored-by: hemosphere <[email protected]>
Co-authored-by: Emil Ernerfeldt <[email protected]>
jleibs pushed a commit that referenced this issue Aug 31, 2023
This Fixes #1867. Setting Alt as the slowdown behaviour for the camera
movement. Note, that this also sets it to alt for wasm architecture, let
me know if you wish for an extra check for wasm (and leave it as alt).

Thanks.

* [X] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [X] I've included a screenshot or gif (if applicable)
* [X] I have tested [demo.rerun.io](https://demo.rerun.io/pr/{{
pr.number }}) (if applicable)

- [PR Build Summary](https://build.rerun.io/pr/{{ pr.number }})
- [Docs preview](https://rerun.io/preview/{{
"pr:%s"|format(pr.branch)|encode_uri_component }}/docs)
- [Examples preview](https://rerun.io/preview/{{
"pr:%s"|format(pr.branch)|encode_uri_component }}/examples)
- [Recent benchmark results](https://ref.rerun.io/dev/bench/)
- [Wasm size tracking](https://ref.rerun.io/dev/sizes/)

---------

Co-authored-by: hemosphere <[email protected]>
Co-authored-by: Emil Ernerfeldt <[email protected]>
jleibs pushed a commit that referenced this issue Aug 31, 2023
This Fixes #1867. Setting Alt as the slowdown behaviour for the camera
movement. Note, that this also sets it to alt for wasm architecture, let
me know if you wish for an extra check for wasm (and leave it as alt).

Thanks.

* [X] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [X] I've included a screenshot or gif (if applicable)
* [X] I have tested [demo.rerun.io](https://demo.rerun.io/pr/{{
pr.number }}) (if applicable)

- [PR Build Summary](https://build.rerun.io/pr/{{ pr.number }})
- [Docs preview](https://rerun.io/preview/{{
"pr:%s"|format(pr.branch)|encode_uri_component }}/docs)
- [Examples preview](https://rerun.io/preview/{{
"pr:%s"|format(pr.branch)|encode_uri_component }}/examples)
- [Recent benchmark results](https://ref.rerun.io/dev/bench/)
- [Wasm size tracking](https://ref.rerun.io/dev/sizes/)

---------

Co-authored-by: hemosphere <[email protected]>
Co-authored-by: Emil Ernerfeldt <[email protected]>
jleibs pushed a commit that referenced this issue Aug 31, 2023
This Fixes #1867. Setting Alt as the slowdown behaviour for the camera
movement. Note, that this also sets it to alt for wasm architecture, let
me know if you wish for an extra check for wasm (and leave it as alt).

Thanks.

* [X] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [X] I've included a screenshot or gif (if applicable)
* [X] I have tested [demo.rerun.io](https://demo.rerun.io/pr/{{
pr.number }}) (if applicable)

- [PR Build Summary](https://build.rerun.io/pr/{{ pr.number }})
- [Docs preview](https://rerun.io/preview/{{
"pr:%s"|format(pr.branch)|encode_uri_component }}/docs)
- [Examples preview](https://rerun.io/preview/{{
"pr:%s"|format(pr.branch)|encode_uri_component }}/examples)
- [Recent benchmark results](https://ref.rerun.io/dev/bench/)
- [Wasm size tracking](https://ref.rerun.io/dev/sizes/)

---------

Co-authored-by: hemosphere <[email protected]>
Co-authored-by: Emil Ernerfeldt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
😤 annoying Something in the UI / SDK is annoying to use 🪳 bug Something isn't working good first issue Good for newcomers 🏎️ Quick Issue Can be fixed in a few hours or less ui concerns graphical user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants