Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track file sizes #3037

Merged
merged 15 commits into from
Aug 18, 2023
Merged

Track file sizes #3037

merged 15 commits into from
Aug 18, 2023

Conversation

jprochazk
Copy link
Member

@jprochazk jprochazk commented Aug 18, 2023

What

Fixes #2511

  • Adds scripts/ci/sizes.py for measuring and comparing file sizes
    • This works for any files, not just WASM files
  • Use the new script in a new reusable_track_size.yml workflow
    • Measures sizes of various files (.wasm, .js, demo .rrd), and uploads the results to GCS
    • Compares the results to main and posts a PR comment if the size changed significantly (+10% or -10%)
    • Builds file size graphs and pushes them to gh-pages on every commit to main
  • Also updated the PR description template to include links to benchmark graphs and the new size graphs.

Checklist

@jprochazk jprochazk added the 🧑‍💻 dev experience developer experience (excluding CI) label Aug 18, 2023
@github-actions
Copy link

github-actions bot commented Aug 18, 2023

Size changes

Name Previous Current Change
Wasm (none) 13.506 MB +100%
JS (none) 107.698 KB +100%
arkit_scenes.rrd (none) 41661.312 KB +100%
detect_and_track_objects.rrd (none) 59530.079 KB +100%
dicom_mri.rrd (none) 64877.033 KB +100%
dna.rrd (none) 781.257 KB +100%
human_pose_tracking.rrd (none) 56953.565 KB +100%
plots.rrd (none) 255.568 KB +100%
structure_from_motion.rrd (none) 7091.426 KB +100%

@jprochazk jprochazk merged commit d8495e0 into main Aug 18, 2023
@jprochazk jprochazk deleted the jan/track-wasm-size branch August 18, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧑‍💻 dev experience developer experience (excluding CI)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Track .wasm size over time
1 participant