Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track .wasm size over time #2511

Closed
Tracked by #2776
emilk opened this issue Jun 26, 2023 · 0 comments · Fixed by #3037
Closed
Tracked by #2776

Track .wasm size over time #2511

emilk opened this issue Jun 26, 2023 · 0 comments · Fixed by #3037
Assignees
Labels
🧑‍💻 dev experience developer experience (excluding CI) enhancement New feature or request

Comments

@emilk
Copy link
Member

emilk commented Jun 26, 2023

I'd like the CI to measure the web-viewer .wasm size and track it over time in a nice plot, perhaps warning when a PR makes it go up by more than 100kB or so

@emilk emilk added enhancement New feature or request 🧑‍💻 dev experience developer experience (excluding CI) labels Jun 26, 2023
@jprochazk jprochazk mentioned this issue Aug 18, 2023
3 tasks
jprochazk added a commit that referenced this issue Aug 18, 2023
<!--
Open the PR up as a draft until you feel it is ready for a proper
review.

Do not make PR:s from your own `main` branch, as that makes it difficult
for reviewers to add their own fixes.

Add any improvements to the branch as new commits to make it easier for
reviewers to follow the progress. All commits will be squashed to a
single commit once the PR is merged into `main`.

Make sure you mention any issues that this PR closes in the description,
as well as any other related issues.

To get an auto-generated PR description you can put "copilot:summary" or
"copilot:walkthrough" anywhere.
-->

### What

Fixes #2511

- Adds `scripts/ci/sizes.py` for measuring and comparing file sizes
  - This works for any files, not just WASM files
- Use the new script in a new `reusable_track_size.yml` workflow
- Measures sizes of various files (`.wasm`, `.js`, demo `.rrd`), and
uploads the results to GCS
- Compares the results to `main` and posts a PR comment if the size
changed significantly (+10% or -10%)
- Builds file size graphs and pushes them to `gh-pages` on every commit
to `main`
- Also updated the PR description template to include links to benchmark
graphs and the new size graphs.

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/3037) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/3037)
- [Docs
preview](https://rerun.io/preview/pr%3Ajan%2Ftrack-wasm-size/docs)
- [Examples
preview](https://rerun.io/preview/pr%3Ajan%2Ftrack-wasm-size/examples)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧑‍💻 dev experience developer experience (excluding CI) enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants