Add support to close a recording #2972
Conversation
abey79
added
enhancement
crates/re_ui/src/command.rs
Outdated
| @@ -86,6 +87,8 @@ impl UICommand { | |||
| #[cfg(not(target_arch = "wasm32"))] | |||
| UICommand::Open => ("Open…", "Open a Rerun Data File (.rrd)"), | |||
|
|
|||
| UICommand::CloseCurrentRecording => ("Close recording", "Close the current Recording"), | |||
There was a problem hiding this comment.
Maybe the tooltip should mention that all data will be lost unrecoverably unless saved?
There was a problem hiding this comment.
Also consider adding the actual name of the recording to the tooltip for added clarity.
There was a problem hiding this comment.
Could also consider using the label "Close current recording" to be more specific. If it doesn't take too much space I think that specificity would make things clearer
There was a problem hiding this comment.
@nikolausWest "dynamic" tooltips would require a significant refactor of that area of code I believe. I'd rather avoid that can of worm in this PR so I'll open an issue. Also, this might be a little-used feature anyways once I add the "delete" button in the recording list.
crates/re_ui/src/command.rs
Outdated
| @@ -86,6 +87,8 @@ impl UICommand { | |||
| #[cfg(not(target_arch = "wasm32"))] | |||
| UICommand::Open => ("Open…", "Open a Rerun Data File (.rrd)"), | |||
|
|
|||
| UICommand::CloseCurrentRecording => ("Close recording", "Close the current Recording"), | |||
There was a problem hiding this comment.
Also consider adding the actual name of the recording to the tooltip for added clarity.
crates/re_ui/src/command.rs
Outdated
| @@ -86,6 +87,8 @@ impl UICommand { | |||
| #[cfg(not(target_arch = "wasm32"))] | |||
| UICommand::Open => ("Open…", "Open a Rerun Data File (.rrd)"), | |||
|
|
|||
| UICommand::CloseCurrentRecording => ("Close recording", "Close the current Recording"), | |||
There was a problem hiding this comment.
Could also consider using the label "Close current recording" to be more specific. If it doesn't take too much space I think that specificity would make things clearer
# Conflicts: # crates/re_viewer/src/ui/recordings_panel.rs
|
Thanks for the reviews. I've changed the command name to "Close current Recording" and opened an issue to improve the tooltip with dynamic info: |
What
This PR adds support to close a recording. Currently, this is available through the Rerun menu and the command palette. A close button will be added to the recording list UI in a subsequent PR.
My choices:
Note: For the web builds, this feature is accessible from the command panel, but not from the rerun menu (which, as discussed, is ok). The drawback is that when all records are closed, the welcome screen shows "Loading..." instead of "Rerun is ready" (as in native builds). This will be addressed when revisiting the welcome screen, and relates to:
http://andws://streams at once withrerun#2121Checklist