Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support loading multiple http:// and ws:// streams at once with rerun #2121

Closed
emilk opened this issue May 15, 2023 · 1 comment
Closed

Support loading multiple http:// and ws:// streams at once with rerun #2121

emilk opened this issue May 15, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@emilk
Copy link
Member

emilk commented May 15, 2023

In #2060 we added support for loading multiple .rrd files at once using rerun foo.rrd bar.rrd. However, this makes us a bit inconsistent, as we do NOT support rerun http://example.com/foo.rrd http://example.com/bar.rrd

The major things we need to accomplish is:

  • We must support having multiple channels as input to an App, and make LogDb::data_source as set. This would be a nice cleanup otherwise
  • How we handle ArgumentCategory::WebSocketAddr needs to change. In particular adding support for multiple web-viewers will take a quite a bit of work.
  • Replace re_smart_channel::Source::Files with just multiple sources over multiple channels
@emilk emilk added enhancement New feature or request 👀 needs triage This issue needs to be triaged by the Rerun team labels May 15, 2023
@emilk emilk removed the 👀 needs triage This issue needs to be triaged by the Rerun team label Jul 4, 2023
@emilk
Copy link
Member Author

emilk commented Aug 25, 2023

Closed in favor of #2229

@emilk emilk closed this as completed Aug 25, 2023
@emilk emilk assigned emilk and unassigned emilk Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants