Add Recordings section to the left panel #2938
Conversation
- created a proper "panel_title_bar" widget in ReUi - removed the recordings submenu from the rerun menu - updated re_ui_example.rs to illustrate the "proper" panel hierarchy and demo the "panel_title_bar" widget.
Note: scroll area breaks the clip rect :(
- recordings now use ListItem and have proper icon - new "canonical" panel hierarchy defined—again! - ListItem has custom icon function now - panel_content() helper function (for the panel frame with inner margins)
abey79
changed the title
|
When I use the |
So does the "Open..." menu item then? It should be doing the same thing. Anyway, I'll take a look tomorrow. |
| // Second section. It's a list of `list_items`, so we need to remove the default | ||
| // spacing. Also, it uses a scroll area, so we must use several `Frame`s. | ||
| ui.scope(|ui| { | ||
| ui.spacing_mut().item_spacing.y = 0.0; |
There was a problem hiding this comment.
so we want to remove the spacing between the title and the items too?
There was a problem hiding this comment.
I think so, though the styling of the title has already changed in the meantime and that is all part of a whole lot of things that will see significant styling adjustment and fine-tuning in the coming weeks (when Mårten is back from holidays).
Yeah you are right, probably not a new bug, just more obvious now (which is a good thing!) |
|
@emilk Great review, thanks! (I learned a bunch on the way.) I've addressed all the comments marked as resolved. I guess the I also fixed the "loaded rrd isn't activated" bug. Maybe you'll want to take a look as I haven't touched that stuff much so far. |
…wouldn't activate it
What
Add Recordings section to the left panel.
Fixes #2298
Also:
ListItemwidget to be used across the UIIconor closure)+button in title to open new recordingDeferred to follow-up PRs:
Checklist
I have tested demo.rerun.io (if applicable)best tested on a native build and throwing lots of example at it, e.g.for run in {1..4}; do python examples/python/dna/main.py --connect; done