Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show open recordings in side view above blueprints #2298

Closed
5 tasks
Tracked by #2695
nikolausWest opened this issue Jun 1, 2023 · 0 comments · Fixed by #2938
Closed
5 tasks
Tracked by #2695

Show open recordings in side view above blueprints #2298

nikolausWest opened this issue Jun 1, 2023 · 0 comments · Fixed by #2938
Assignees
@abey79
Labels
enhancement New feature or request ui concerns graphical user interface

Comments

@nikolausWest
Copy link
Member

nikolausWest commented Jun 1, 2023 •
edited by abey79
Loading

Managing recordings (seeing currently open, switching, and opening new recordings) is currently hidden under the Rerun menu. It's useful to keep track of what recording is currently open. In addition, open recordings take up memory so it's useful to see how many are open and to easily close recordings that shouldn't be.

Demo video for new design:
https://github.com/rerun-io/rerun/assets/2624717/b83a3aee-0305-48d9-82bf-83327ba0963e

Link to Figma design: https://www.figma.com/file/3WX8yUqa8ECmhLwV6NIF3a/Rerun-Design-System?type=design&node-id=2698%3A21576&t=AjbICV0m6HjAd7UR-1

TODO

  • Move all recording actions from the Rerun menu to above the blueprint in the left view according to the design
    • All open recordings with matching app ID are listed
    • Possible to change active recording by clicking
    • Close recording by pressing close button (X)
    • Open new recording by pressing the + button
@nikolausWest nikolausWest added enhancement New feature or request 👀 needs triage This issue needs to be triaged by the Rerun team ui concerns graphical user interface and removed 👀 needs triage This issue needs to be triaged by the Rerun team labels Jun 1, 2023
This was referenced Jun 1, 2023
Closed
Closed
Closed
@abey79 abey79 self-assigned this Jun 7, 2023
@nikolausWest nikolausWest mentioned this issue Jul 14, 2023
Open
13 tasks
This was referenced Aug 7, 2023
Closed
Merged
abey79 added a commit that referenced this issue Aug 11, 2023
@abey79
Add Recordings section to the left panel (#2938)
4f2fe7d 
### What

Add Recordings section to the left panel.

Fixes #2298

Also:
- [x] created a brand new `ListItem` widget to be used across the UI
  - full-span highlight
  - icon support (`Icon` or closure)
  - hover button support
- [x] created a proper "panel_title_bar" widget in ReUi
- [x] removed the recordings submenu from the rerun menu
- [x] updated re_ui_example.rs to illustrate the "proper" panel
hierarchy and demo the new widgets
- [x] `+` button in title to open new recording

Deferred to follow-up PRs:
- hierarchical display
- minus hover button to close the recording

<img width="1412" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/dd761936-bd5d-4161-b7c2-353652cf1897">


### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] ~~I have tested [demo.rerun.io](https://demo.rerun.io/pr/2938) (if
applicable)~~ best tested on a native build and throwing lots of example
at it, e.g. `for run in {1..4}; do python examples/python/dna/main.py
--connect; done`

- [PR Build Summary](https://build.rerun.io/pr/2938)
- [Docs
preview](https://rerun.io/preview/pr%3Aantoine%2Fnew-recording-ui-2298/docs)
- [Examples
preview](https://rerun.io/preview/pr%3Aantoine%2Fnew-recording-ui-2298/examples)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abey79 abey79

Labels
enhancement New feature or request ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Recordings section to the left panel rerun-io/rerun
2 participants
@nikolausWest @abey79