Pass through strings using arrow2::Buffers #2931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleibs
force-pushed
the
jleibs/primitive_buffers
branch
from
2547eff to
5e2ff49
Compare
3 tasks
jleibs
force-pushed
the
jleibs/primitive_buffers
branch
from
5e2ff49 to
bd2c2ac
Compare
jleibs
force-pushed
the
jleibs/primitive_buffers
branch
from
33e3c1a to
87d1b4b
Compare
jleibs
force-pushed
the
jleibs/strings_and_bench
branch
from
5eae3dd to
603778d
Compare
jleibs
force-pushed
the
jleibs/primitive_buffers
branch
from
87d1b4b to
304e01d
Compare
teh-cmc
approved these changes
Aug 8, 2023
Comment on lines
+2322
to
+2325
| arrow2::bitmap::utils::ZipValidity::new_with_validity( | ||
| offsets.iter().zip(offsets.lengths()), | ||
| downcast.validity(), | ||
| ) |
There was a problem hiding this comment.
Nice, I probably could've used that in a few places 😅
|
Does this close #1887 ? |
It's at least related. This only affects code-generated strings, so we need to migrate TextEntry to codegen. Also need to take a look at how the TextEntry query results are used to make sure we aren't gratuitously converting them back to strings somewhere in the query path. |
jleibs
added a commit
that referenced
this pull request
Aug 8, 2023
### What Add a new benchmark of strings so we can verify the move to buffers in #2931 is actually an improvement. ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2926) (if applicable) - [PR Build Summary](https://build.rerun.io/pr/2926) - [Docs preview](https://rerun.io/preview/pr%3Ajleibs%2Fstrings_and_bench/docs) - [Examples preview](https://rerun.io/preview/pr%3Ajleibs%2Fstrings_and_bench/examples)
jleibs
force-pushed
the
jleibs/primitive_buffers
branch
from
304e01d to
3940e90
Compare
3 tasks
This was referenced Aug 30, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This avoids copying strings and lets us end up with
&strreferences pointed directly at the underlying arrow buffer.1.8x speedup on mono_strings and 8.7x speedup on batch strings:
Checklist