Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Crude first attempt to use &str's instead of Strings #2915

Closed
wants to merge 2 commits into from

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Aug 4, 2023

What

First pass of making the code-gen system use &strs instead of needing to copy all the strings. Also paves the way for using references on other array-types as necessary.

Big complication to resolve now is how to handle these reference lifetimes when it comes to interacting with the store.

Checklist

@jleibs jleibs added the do-not-merge Do not merge this PR label Aug 4, 2023
@jleibs jleibs closed this Aug 25, 2023
@jleibs
Copy link
Member Author

jleibs commented Aug 25, 2023

Was obsoleted by: #2931

@jleibs jleibs deleted the jleibs/hope_text branch June 14, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge Do not merge this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant