-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New triangle collapse arrow for large collapsible header #2920
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good visually!
As we discussed on the huddle, there will be many icons, so it's good if adding icons isn't messy code wise or takes a lot of time. Some approaches we talked about:
- Linearizing the paths like this PR does
- Extracting path data from SVG attributes
- Apple approach: Adding multiple images like [email protected], [email protected] etc and choosing them based on ui zoom level.
Anyways, I'll leave this to you!
Yes, that's on my long list of topics to run by @emilk. That being said and regardless of where we're going with icons in general, the collapsing arrow may deserve special treatment because of the rotation animation. I think this is the lens with which this PR should be evaluated. |
One clear shortcoming of this PR is that it doesn't document how I came up with the coordinates. I don't think the process is clean enough to be included though. For reference, here is the command I used:
where:
Edit: BTW the ridiculous chaining of various scaling commands is the result of my process back then btw. Should definitely be cleaned up as well. |
We should create a proper issue about how to do icons. Some quick, random thoughts: There are at least three things to consider:
There are two major ways to go. Imagers (e.g. .png)
Vector graphicsUsing Dor concave polygons we either need to implement something new in epaint, or use some 3rd party rendering tool (more code bloat)
Conclusions?I'm leaning towards using a single high-res .png for each icon, then resize it using some high-quality algo (e.g. Lanczos filtering) to create a crisp icon for the current resolution scaling. Easy to use, easy to implement, high-quality, low code bloat. |
Icon discussion moved here: #2960 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
pos2(0.286141, -0.029362), | ||
pos2(0.316248, -0.017085), | ||
pos2(0.80387, 0.470537), | ||
]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps link to #2960 here so we remember to update this code once that issue is resolved
What
This PR implements the proper Figma-based collapsing arrow (with "linearised" rounded corners) and uses it for the large collapsible headers in the selection panel. This PR also fixes the vertical optical alignment of the text within these headers.
Partially addresses #2738
Zoom 150%:
Checklist