-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve drag tab UI #2893
Improve drag tab UI #2893
Conversation
# Conflicts: # crates/re_viewport/src/viewport.rs
@martenbjork re: overlay effects while dragging. The current solution is the following:
When the web demo is updated you might want to check it out and we can adjust these parameters. |
Nice! I think that works pretty well. Another small step towards making the UI feel like one big whole. (The colors are a tad dull, but we can tweak it down the road when we've made some other design choices that might undull the UI. Regardless, that's on me 😀) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now it feels that the actual tab is being dragged, no some different looking thing.
🥰💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love it. Nice sideeffect that it also correctly distuinguishes between selected and unselected things being dragged - which seems weird at first but totally makes sense
@@ -477,3 +452,107 @@ fn space_view_ui( | |||
|
|||
space_view_blueprint.scene_ui(space_view_state, ctx, ui, latest_at, space_view_highlights); | |||
} | |||
|
|||
struct TabWidget { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very tidy, neat. I'd make it its own module but that's more of a taste thing I reckon :)
What
This PR includes the following:
[patch]
, so a release of egui_tiles is needed soon after we merge this:Behaviour
egui_tiles#16tiles
argument toBehavior
functions egui_tiles#17TODO:
Note
Do not review commit-by-commit, I messed my rebase/merges
Checklist