Make drag preview style customisable #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Wumpf
approved these changes
Aug 2, 2023
abey79
added a commit
to rerun-io/rerun
that referenced
this pull request
Aug 2, 2023
### What This PR includes the following: - Improves the UI of the dragged tab UI. Now it feels that the actual tab is being dragged, no some different looking thing. I applied 0.5 transparency on it. - Styles the source and destination areas during the drag (actual styling TBD). - Syncs with egui_tiles's master and includes a `[patch]`, so a release of egui_tiles is needed soon after we merge this: - rerun-io/egui_tiles#16 - rerun-io/egui_tiles#17 - rerun-io/egui_tiles#18 TODO: - [x] fine tune overlay colours - [x] make overlay colours customisable in egui_tiles - [x] cleanup code (currently lots of redundancy) >[!NOTE] >Do not review commit-by-commit, I messed my rebase/merges  ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2893) (if applicable) - [PR Build Summary](https://build.rerun.io/pr/2893) - [Docs preview](https://rerun.io/preview/pr%3Aantoine%2Ftab-drag-ui/docs) - [Examples preview](https://rerun.io/preview/pr%3Aantoine%2Ftab-drag-ui/examples)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR factors out to functions out of
Behavior<_>::pain_drag_preview()to enable customisation of the overlay stroke and colour.