Allow changing plot aspect ratio with scroll + cmd/ctrl + alt #2742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
added
enhancement
teh-cmc
approved these changes
Jul 19, 2023
|
wait what? It's the opposite for me. When I go |
|
seems to be another instance of sticky modifiers on the web T_T |
3 tasks
Yeah actually I can confirm that CTRL has buggy sticky behavior on web, even outside the context of this PR. Sometimes the web viewer is just convinced that I'm pressing CTRL for seemingly no reason 🤷♂️ |
|
@teh-cmc so.. let's treat this as orthogonal and land this aging PR anyways? 🤔 On the flipside it makes sticky modifier problem worse |
|
I don't mind either way. In my case it makes the UX worse on Firefox but better on Chromium so maybe that's fine 🤷 |
|
more users asking for this, let's merge it and tackle the browser issue separately |
emilk
pushed a commit
that referenced
this pull request
Aug 17, 2023
<!-- Open the PR up as a draft until you feel it is ready for a proper review. Do not make PR:s from your own `main` branch, as that makes it difficult for reviewers to add their own fixes. Add any improvements to the branch as new commits to make it easier for reviewers to follow the progress. All commits will be squashed to a single commit once the PR is merged into `main`. Make sure you mention any issues that this PR closes in the description, as well as any other related issues. To get an auto-generated PR description you can put "copilot:summary" or "copilot:walkthrough" anywhere. --> ### What Wanted Shift+Cmd originally, but egui no longer see this as a scroll then. Also, shift+scroll is already taken for translating along y. Fixes #2148 * #2148 https://github.com/rerun-io/rerun/assets/1220815/bc078094-4bae-4980-8508-af0cff234614 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2742) (if applicable) - [PR Build Summary](https://build.rerun.io/pr/2742) - [Docs preview](https://rerun.io/preview/pr%3Aandreas%2Fsingle-axis-plot-zoom/docs) - [Examples preview](https://rerun.io/preview/pr%3Aandreas%2Fsingle-axis-plot-zoom/examples)
emilk
pushed a commit
that referenced
this pull request
Aug 17, 2023
<!-- Open the PR up as a draft until you feel it is ready for a proper review. Do not make PR:s from your own `main` branch, as that makes it difficult for reviewers to add their own fixes. Add any improvements to the branch as new commits to make it easier for reviewers to follow the progress. All commits will be squashed to a single commit once the PR is merged into `main`. Make sure you mention any issues that this PR closes in the description, as well as any other related issues. To get an auto-generated PR description you can put "copilot:summary" or "copilot:walkthrough" anywhere. --> ### What Wanted Shift+Cmd originally, but egui no longer see this as a scroll then. Also, shift+scroll is already taken for translating along y. Fixes #2148 * #2148 https://github.com/rerun-io/rerun/assets/1220815/bc078094-4bae-4980-8508-af0cff234614 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2742) (if applicable) - [PR Build Summary](https://build.rerun.io/pr/2742) - [Docs preview](https://rerun.io/preview/pr%3Aandreas%2Fsingle-axis-plot-zoom/docs) - [Examples preview](https://rerun.io/preview/pr%3Aandreas%2Fsingle-axis-plot-zoom/examples)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Wanted Shift+Cmd originally, but egui no longer see this as a scroll then. Also, shift+scroll is already taken for translating along y.
Fixes #2148
Screen.Recording.2023-07-18.at.16.06.29.mov
Checklist