Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easy to zoom in on only a single axis in a plot #2148

Closed
Wumpf opened this issue May 16, 2023 · 2 comments · Fixed by #2742
Closed

Make it easy to zoom in on only a single axis in a plot #2148

Wumpf opened this issue May 16, 2023 · 2 comments · Fixed by #2742
Assignees
Labels
😤 annoying Something in the UI / SDK is annoying to use enhancement New feature or request 🏎️ Quick Issue Can be fixed in a few hours or less 📺 re_viewer affects re_viewer itself

Comments

@Wumpf
Copy link
Member

Wumpf commented May 16, 2023

We have selection rectangle based selection that can change the ratio between the axis but there's no scroll + X shortcut to zoom in just Y or X axis.

@Wumpf Wumpf added enhancement New feature or request 📺 re_viewer affects re_viewer itself 😤 annoying Something in the UI / SDK is annoying to use labels May 16, 2023
@MichalLebeda
Copy link

I suggest CTRL + Scroll for Y axis and CTRL + Shift + Scroll for X axis but others may have different preferences. Would suggest to keep normal scroll scale both axes.

@Wumpf Wumpf added the 🏎️ Quick Issue Can be fixed in a few hours or less label May 17, 2023
@Wumpf Wumpf self-assigned this Jul 18, 2023
@Wumpf
Copy link
Member Author

Wumpf commented Jul 18, 2023

ended up using a different shortcut, see #2742

Wumpf added a commit that referenced this issue Aug 6, 2023
<!--
Open the PR up as a draft until you feel it is ready for a proper
review.

Do not make PR:s from your own `main` branch, as that makes it difficult
for reviewers to add their own fixes.

Add any improvements to the branch as new commits to make it easier for
reviewers to follow the progress. All commits will be squashed to a
single commit once the PR is merged into `main`.

Make sure you mention any issues that this PR closes in the description,
as well as any other related issues.

To get an auto-generated PR description you can put "copilot:summary" or
"copilot:walkthrough" anywhere.
-->

### What

Wanted Shift+Cmd originally, but egui no longer see this as a scroll
then. Also, shift+scroll is already taken for translating along y.

Fixes #2148
* #2148



https://github.com/rerun-io/rerun/assets/1220815/bc078094-4bae-4980-8508-af0cff234614



### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2742) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/2742)
- [Docs
preview](https://rerun.io/preview/pr%3Aandreas%2Fsingle-axis-plot-zoom/docs)
- [Examples
preview](https://rerun.io/preview/pr%3Aandreas%2Fsingle-axis-plot-zoom/examples)
emilk pushed a commit that referenced this issue Aug 17, 2023
<!--
Open the PR up as a draft until you feel it is ready for a proper
review.

Do not make PR:s from your own `main` branch, as that makes it difficult
for reviewers to add their own fixes.

Add any improvements to the branch as new commits to make it easier for
reviewers to follow the progress. All commits will be squashed to a
single commit once the PR is merged into `main`.

Make sure you mention any issues that this PR closes in the description,
as well as any other related issues.

To get an auto-generated PR description you can put "copilot:summary" or
"copilot:walkthrough" anywhere.
-->

### What

Wanted Shift+Cmd originally, but egui no longer see this as a scroll
then. Also, shift+scroll is already taken for translating along y.

Fixes #2148
* #2148



https://github.com/rerun-io/rerun/assets/1220815/bc078094-4bae-4980-8508-af0cff234614



### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2742) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/2742)
- [Docs
preview](https://rerun.io/preview/pr%3Aandreas%2Fsingle-axis-plot-zoom/docs)
- [Examples
preview](https://rerun.io/preview/pr%3Aandreas%2Fsingle-axis-plot-zoom/examples)
emilk pushed a commit that referenced this issue Aug 17, 2023
<!--
Open the PR up as a draft until you feel it is ready for a proper
review.

Do not make PR:s from your own `main` branch, as that makes it difficult
for reviewers to add their own fixes.

Add any improvements to the branch as new commits to make it easier for
reviewers to follow the progress. All commits will be squashed to a
single commit once the PR is merged into `main`.

Make sure you mention any issues that this PR closes in the description,
as well as any other related issues.

To get an auto-generated PR description you can put "copilot:summary" or
"copilot:walkthrough" anywhere.
-->

### What

Wanted Shift+Cmd originally, but egui no longer see this as a scroll
then. Also, shift+scroll is already taken for translating along y.

Fixes #2148
* #2148



https://github.com/rerun-io/rerun/assets/1220815/bc078094-4bae-4980-8508-af0cff234614



### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2742) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/2742)
- [Docs
preview](https://rerun.io/preview/pr%3Aandreas%2Fsingle-axis-plot-zoom/docs)
- [Examples
preview](https://rerun.io/preview/pr%3Aandreas%2Fsingle-axis-plot-zoom/examples)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
😤 annoying Something in the UI / SDK is annoying to use enhancement New feature or request 🏎️ Quick Issue Can be fixed in a few hours or less 📺 re_viewer affects re_viewer itself
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants